More checks around num_entries vs. num_deletions #12600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We've seen an internal crash test+sanitizer failure seemingly caused by underflow on `current_num_non_deletions_` which would happen if num_entries < num_deletions. (T186407810) This change adds an additional check (fail earlier?) and coerces read table properties to satisfy the invariant that is supposed to be provided by facebook#4841 but could be violated by older files, due to facebook#4016. Test Plan: existing tests
|
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ajkr
approved these changes
May 2, 2024
| // Ensure new invariants on old files | ||
| file_meta->num_deletions = | ||
| std::max(tp->num_deletions, tp->num_range_deletions); | ||
| file_meta->num_entries = std::max(tp->num_entries, tp->num_deletions); |
There was a problem hiding this comment.
I think tp->num_entries >= tp->num_deletions even for old files. Did you mean std::max(tp->num_entries, tp->num_range_deletions);?
There was a problem hiding this comment.
Just being slightly more proactive against unexpected serialized data breaking an invariant.
|
@pdillinger merged this pull request in a178d15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We've seen an internal crash test+sanitizer failure seemingly caused by underflow on
current_num_non_deletions_which would happen if num_entries < num_deletions. (T186407810)This change adds an additional check (fail earlier?) and coerces read table properties to satisfy the invariant that is supposed to be provided by #4841 but could be violated by older files, due to
#4016.
Test Plan: existing tests