Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wraparound in SstFileManager #13010

Closed
wants to merge 1 commit into from

Commits on Sep 13, 2024

  1. Fix wraparound in SstFileManager (facebook#13010)

    Summary:
    Pull Request resolved: facebook#13010
    
    The OnAddFile cur_compactions_reserved_size_ accounting causes wraparound when re-opening a database with an unowned SstFileManager and during recovery. It was introduced in facebook#4164 which addresses out of space recovery with an unclear purpose. Compaction jobs do this accounting via EnoughRoomForCompaction/OnCompactionCompletion and to my understanding would never reuse a sst file name.
    
    Reviewed By: anand1976
    
    Differential Revision: D62535775
    Nick Brekhus authored and facebook-github-bot committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8ead297 View commit details
    Browse the repository at this point in the history