Add [set]DailyOffpeakTimeUTC option to Java API #13148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflect RocksDB DailyOffpeakTimeUTC option in Java API. As is standard for options, there are a number of different places where this option needs to be added. The new option is a string value. This requires an extension to the internal MutableDBOptions parse code, which received the entire options string from C++ and parses it on the Java side.
rhubner
reviewed
Nov 19, 2024
rhubner
reviewed
Nov 19, 2024
| @@ -759,6 +759,19 @@ public long compactionReadaheadSize() { | |||
| return compactionReadaheadSize(nativeHandle_); | |||
| } | |||
|
|
|||
| @Override | |||
| public DBOptions setDailyOffpeakTimeUTC(String offpeakTimeUTC) { | |||
There was a problem hiding this comment.
I think this is good design. Somebody can say that java date/time data structures can be better, but conversion will probably make more problems. 👍
There was a problem hiding this comment.
I thought hard about that. If I would use the the java date/time, I need to parse the HH:mm-HH:mm format. Better to just present the same string as RockSDB does.
|
LGTM |
alanpaxton
force-pushed
the
eb/java-offpeak-compaction-options
branch
from
2bb94d2 to
a5cc7ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflect RocksDB DailyOffpeakTimeUTC option in Java API. As is standard for options, there are a number of different places where this option needs to be added: it is an option, a DB option, and it is mutable (can be changed while running).
The new option is a string value. This requires an extension to the internal MutableDBOptions parse code, which received the entire options string from C++ and parses it on the Java side.