Turn Transaction into a pure interface class #13153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: As groundwork for further work, the patch changes `Transaction` to be an abstract interface class with no data members by moving the current members `log_number_`, `name_`, `txn_state_`, and `id_` (as well as the implementations of the methods accessing them) to `TransactionBaseImpl`. Note that this involves some minor API changes : `SetLogNumber`, `GetLogNumber`, `GetName`, `SetId`, and `GetLastLogNumber` are now pure virtual in `Transaction` instead of (non-pure) virtual, and `GetState`, `SetState`, and `GetId` are pure virtual instead of non-virtual. Differential Revision: D66386696
|
This pull request was exported from Phabricator. Differential Revision: D66386696 |
jowlyzhang
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As groundwork for further work, the patch changes
Transactionto be an abstract interface class with no data members by moving the current memberslog_number_,name_,txn_state_, andid_(as well as the implementations of the methods accessing them) toTransactionBaseImpl. Note that this involves some minor API changes :SetLogNumber,GetLogNumber,GetName,SetId, andGetLastLogNumberare now pure virtual inTransactioninstead of non-pure virtual, andGetState,SetState, andGetIdare pure virtual instead of non-virtual. The patch also removes an unused protectedTransactionconstructor.Differential Revision: D66386696