Add abort check to yield hook #13164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbi42
approved these changes
Nov 27, 2024
|
@george-reynya has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@george-reynya merged this pull request in 6f9d826. |
cbi42
pushed a commit
to cbi42/rocksdb
that referenced
this pull request
Nov 30, 2024
Summary: Adding ability to kill mysql queries traversing long lists of tombstones. Outside of mysql where RocksDbThreadYieldAndCheckAbort is not implemented all of this should still be optimized out by the compiler. Pull Request resolved: facebook#13164 Reviewed By: cbi42 Differential Revision: D66556004 Pulled By: george-reynya fbshipit-source-id: 727875569209cd6d2f29c07f89ecfa641d5ee36f
cbi42
pushed a commit
that referenced
this pull request
Nov 30, 2024
Summary: Adding ability to kill mysql queries traversing long lists of tombstones. Outside of mysql where RocksDbThreadYieldAndCheckAbort is not implemented all of this should still be optimized out by the compiler. Pull Request resolved: #13164 Reviewed By: cbi42 Differential Revision: D66556004 Pulled By: george-reynya fbshipit-source-id: 727875569209cd6d2f29c07f89ecfa641d5ee36f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ability to kill mysql queries traversing long lists of tombstones. Outside of mysql where RocksDbThreadYieldAndCheckAbort is not implemented all of this should still be optimized out by the compiler.