Generalize and move the wide-column Find method to facilitate reuse #13168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The patch moves `WideColumnSerialization::Find` to `WideColumnsHelper` to facilitate reuse in non-serialization-related contexts. It also generalizes the method to take a range of iterators, and templatizes it on the iterator type to enable using it with both `const` and non-`const` iterators. Finally, it adds an assertion to ensure the method is called with a properly sorted range, which is a precondition for binary search. Differential Revision: D66602558
|
This pull request was exported from Phabricator. Differential Revision: D66602558 |
jaykorean
reviewed
Dec 2, 2024
|
|
||
| template <typename Iterator> | ||
| static Iterator Find(Iterator begin, Iterator end, const Slice& column_name) { | ||
| assert(std::is_sorted(begin, end, |
There was a problem hiding this comment.
QQ. Does the check inside assert() get ignored automatically in non-debug build?
If not, I'm wondering if we want to wrap this assertion in #ifndef NDEBUG
There was a problem hiding this comment.
QQ. Does the check inside
assert()get ignored automatically in non-debug build?
Yes, it is a no-op in non-debug builds
jaykorean
approved these changes
Dec 2, 2024
|
This pull request has been merged in 346055a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The patch moves
WideColumnSerialization::FindtoWideColumnsHelperto facilitate reuse in non-serialization-related contexts. It also generalizes the method to take a range of iterators, and templatizes it on the iterator type to enable using it with bothconstand non-constiterators. Finally, it adds an assertion to ensure the method is called with a properly sorted range, which is a precondition for binary search.Differential Revision: D66602558