rocksdb/db.h: GetDbIdentity comment: ID comes from MANIFEST #13193
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 98c33cb changed the default for the write_dbid_to_manifest option, so this ID now comes from MANIFEST and not IDENTITY. Update the comment to reflect that. Remove 2 unneeded words from the comment on GetDbSessionId since it refers to this function.
evanj
force-pushed
the
evan.jones/identity-comment
branch
from
cdd9ce6 to
4a08c0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 98c33cb changed the default for the write_dbid_to_manifest option, so this ID now comes from MANIFEST and not IDENTITY. Update the comment to reflect that.
Remove 2 unneeded words from the comment on GetDbSessionId since it refers to this function.