Add time measuring metrics for file ingestion in PerfContext #13219
+79
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jowlyzhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hx235
reviewed
Dec 19, 2024
| // These metrics usually have this pattern: "_[wait|delay]_*_[time|nanos]". | ||
| kEnableWait = 3, | ||
| // Starts enabling metrics that measure the end to end time of an operation. | ||
| // These metrics' names have keywords "time" or "nanos". Check other time |
There was a problem hiding this comment.
nit: "time" or time unit e.g, nanos, micros.
hx235
reviewed
Dec 19, 2024
| opts.allow_blocking_flush = true; | ||
| ASSERT_OK(db_->IngestExternalFile({file1}, opts)); | ||
| ASSERT_EQ(perf_context.file_ingestion_nanos, 0); | ||
| ASSERT_EQ(perf_context.file_ingestion_blocking_live_writes_nanos, 0); |
There was a problem hiding this comment.
I assumed your test ensure blocking live writes will happen so this proves your point.
hx235
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled. And also added some documentation for an approach to name perf context metrics that can help identify the starting
PerfLevelthat enables collecting it.Test Plan
Unit test