Fix GetMergeOperands() in ReadOnly and SecondaryDB #13396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbi42
force-pushed
the
fix-get-merge-operand
branch
from
fd8f65a to
709fe42
Compare
|
@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jaykorean
approved these changes
Feb 12, 2025
cbi42
force-pushed
the
fix-get-merge-operand
branch
from
709fe42 to
0d7b645
Compare
|
@cbi42 has updated the pull request. You must reimport the pull request before landing. |
Thanks for the review. I think you had another fix for GetMergeOperands() and that release note should be good. |
|
@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Noticed that the
do_mergeparameter is not properly set while working on memtable code.Test plan: updated unit test for the read-only db case.