hdfs cleanup and compile test against CDH 4.4. #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| virtual Status Fsync() { | ||
| //if (fsync(fd_) == -1) { | ||
| // return IOError("directory", errno); | ||
| // } |
There was a problem hiding this comment.
Can you remove the comments here and in the destructor?
|
This is great, thanks! I have couple of inline comments, but overall looks great. |
added 2 commits
May 21, 2014 07:50
- fix compile error with env_test; static casts added
|
Igor - thanks for the feedback. |
igorcanadi
added a commit
that referenced
this pull request
May 21, 2014
hdfs cleanup and compile test against CDH 4.4.
Nazgolze
pushed a commit
to Nazgolze/rocksdb-1
that referenced
this pull request
Sep 21, 2021
Little-Wallace
added a commit
to Little-Wallace/rocksdb
that referenced
this pull request
Dec 9, 2021
* perform like normal pipelined write Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
BusyJay
pushed a commit
to BusyJay/rocksdb
that referenced
this pull request
Jul 25, 2022
* add multibatch write into memtable (facebook#131) Signed-off-by: Little-Wallace <bupt2013211450@gmail.com> Support write multiple WriteBatch into RocksDB together. These WriteBatch will be assigned sequence number in order and pushed into queue. If a thread is waiting for some state, it could steal some job from work queue. Signed-off-by: tabokie <xy.tao@outlook.com> * Improve Multi Batch Write (facebook#154) * perform like normal pipelined write Signed-off-by: Little-Wallace <bupt2013211450@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com> * pass enable_multi_thread_write to BuildDBOptions (facebook#170) Signed-off-by: Little-Wallace <bupt2013211450@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com> * Fix life time of `memtable_write_group` (facebook#171) * fix life time of memtable_write_group Signed-off-by: Little-Wallace <bupt2013211450@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com> * Commit pipeline when write a WriteBatch for linearizability (facebook#267) * support commit pipeline Signed-off-by: Little-Wallace <bupt2013211450@gmail.com> Signed-off-by: tabokie <xy.tao@outlook.com> * format Signed-off-by: tabokie <xy.tao@outlook.com> * remove useless code Signed-off-by: tabokie <xy.tao@outlook.com> Co-authored-by: Wallace <bupt2013211450@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hdfs access for public hadoop distributions. Compiles and tested (using db_bench) on CDH 4.4.