CoreLocalArray class #2256
Closed
CoreLocalArray class #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Closed
|
ping |
lightmark
approved these changes
May 10, 2017
|
@ajkr updated the pull request - view changes - changes since last import |
|
@ajkr updated the pull request - view changes - changes since last import |
|
@ajkr updated the pull request - view changes - changes since last import |
|
@ajkr updated the pull request - view changes - changes since last import |
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Looks like Windows build is failing. @ajkr mind send a fix? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the logic for core-local array out of ConcurrentArena and into a separate class because I want to reuse it for core-local stats.
Test Plan:
setup:
TEST_TMPDIR=/dev/shm ./db_bench -benchmarks=fillrandom -threads=16 -num=1000000 --allow_concurrent_memtable_writebefore this diff:
fillrandom : 2.934 micros/op 340831 ops/sec; 37.7 MB/safter this diff:
fillrandom : 2.944 micros/op 339659 ops/sec; 37.6 MB/s