Fix regression test failures introduced by PR #4164 #4375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: 1. Add override keyword to overridden virtual functions in EventListener 2. Fix a memory corruption that can happen during DB shutdown when in read-only mode due to a background write error 3. Fix uninitialized buffers in error_handler_test.cc that cause valgrind to complain Test Plan: make check make check (clang) make valgrind_test make ubsan_check Test Plan: Reviewers: Subscribers: Tasks: Tags:
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
ajkr
approved these changes
Sep 17, 2018
| @@ -237,7 +239,6 @@ TEST_F(DBErrorHandlingTest, CorruptionError) { | |||
| Destroy(options); | |||
| } | |||
|
|
|||
| #ifndef TRAVIS | |||
There was a problem hiding this comment.
Yes! I didn't have a way of reproducing the travis failure before, but luckily the regression tests caught it.
There was a problem hiding this comment.
anand1976 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
read-only mode due to a background write error
valgrind to complain
Test Plan:
make check
make check (clang)
make valgrind_test
make ubsan_check