Remove enable_internal_stats #4714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@adam-singer has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This was referenced Nov 28, 2019
yiwu-arbug
pushed a commit
to tikv/rocksdb
that referenced
this pull request
Jan 7, 2020
The changes are: - make `StatisticsImpl` as a template - remove internal stats due to facebook#4714
tabokie
pushed a commit
to tabokie/rocksdb
that referenced
this pull request
May 11, 2022
The changes are: - make `StatisticsImpl` as a template - remove internal stats due to facebook#4714 Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
pushed a commit
to tikv/rocksdb
that referenced
this pull request
May 12, 2022
The changes are: - make `StatisticsImpl` as a template - remove internal stats due to facebook#4714 Signed-off-by: tabokie <xy.tao@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple patch to address comments in statistics.h#L65
TODO(ajkr): clean this up since there are no internal stats anymore