Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BlobDB] Move timer queue based tasks to repeatable threads #4908

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sagar0
Copy link
Contributor

@sagar0 sagar0 commented Jan 23, 2019

Switch to using RepeatableThread in BlobDB instead of TimerQueue.

  • We were using TimerQueue in BlobDB to run tasks at fixed intervals. With the introduction of RepeatableThread, we no longer need to rely on TimerQueue code.
  • Remove all reference to TimerQueue.

Test Plan:
Run all tests using make check. Test with clang as well using: USE_CLANG=1 make all

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@sagar0 has updated the pull request. Re-import the pull request

@facebook-github-bot
Copy link
Contributor

Hi @sagar0!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@cscetbon
Copy link

cscetbon commented Mar 3, 2023

did we lose @sagar0 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants