Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build failures due to missing JEMALLOC_CXX_THROW macro #5053

Closed
wants to merge 2 commits into from
Closed

Fix build failures due to missing JEMALLOC_CXX_THROW macro #5053

wants to merge 2 commits into from

Conversation

yiwu-arbug
Copy link
Contributor

@yiwu-arbug yiwu-arbug commented Mar 8, 2019 •
edited by sagar0
Loading

Summary:
JEMALLOC_CXX_THROW is not defined for earlier versions of jemalloc (e.g. 3.6), causing builds to fail on some platforms. Fixing it. Closes #4869

Test Plan:
On both ubuntu 18.04 (with jemalloc-3.6) and ubuntu 18.10 (with jemalloc-5.1.0), run make util/jemalloc_nodump_allocator.o

@yiwu-arbug yiwu-arbug mentioned this pull request Mar 8, 2019
Closed
@sagar0
Copy link
Contributor

sagar0 commented Mar 8, 2019 •
edited
Loading

In #4943 @adamretter seems to have encountered an issue with malloc_usable_size as well in line 46. @yiwu-arbug : should that be fixed as well?

@yiwu-arbug
Copy link
Contributor Author

In #4943 @adamretter seems to have encountered an issue with malloc_usable_size as well. @yiwu-arbug : should that be fixed as well?

malloc_usable_size failure is due to JEMALLOC_CXX_THROW missing. Same issue.

@sagar0
Copy link
Contributor

sagar0 commented Mar 8, 2019

malloc_usable_size failure is due to JEMALLOC_CXX_THROW missing. Same issue.

Oh, my bad, I missed that. looks good then.

facebook-github-bot
facebook-github-bot reviewed Mar 8, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@yiwu-arbug has updated the pull request. Re-import the pull request

@sagar0 sagar0 changed the title Fix JEMALLOC_CXX_THROW macro missing with older Jemalloc Fix build failures due to missing JEMALLOC_CXX_THROW macro Mar 9, 2019
facebook-github-bot
facebook-github-bot reviewed Mar 9, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Mar 9, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagar0 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yiwu-arbug yiwu-arbug deleted the je_throw branch March 17, 2019 00:26
absolute8511 pushed a commit to absolute8511/rocksdb that referenced this pull request Apr 10, 2019
@absolute8511
Fix build failures due to missing JEMALLOC_CXX_THROW macro (facebook#…
b27d508 
…5053)

Summary:
JEMALLOC_CXX_THROW is not defined for earlier versions of jemalloc (e.g. 3.6), causing builds to fail on some platforms. Fixing it. Closes facebook#4869
Pull Request resolved: facebook#5053

Differential Revision: D14390034

Pulled By: sagar0

fbshipit-source-id: b2b7a03cd377201ef385eb521f65bae85c558055
gfosco pushed a commit that referenced this pull request Apr 23, 2019
Fix build failures due to missing JEMALLOC_CXX_THROW macro (#5053)
f9fc8c6 
Summary:
JEMALLOC_CXX_THROW is not defined for earlier versions of jemalloc (e.g. 3.6), causing builds to fail on some platforms. Fixing it. Closes #4869
Pull Request resolved: #5053

Differential Revision: D14390034

Pulled By: sagar0

fbshipit-source-id: b2b7a03cd377201ef385eb521f65bae85c558055
vagogte pushed a commit to vagogte/rocksdb that referenced this pull request Jun 18, 2019
@facebook-github-bot
Fix build failures due to missing JEMALLOC_CXX_THROW macro (facebook#…
127b615 
…5053)

Summary:
JEMALLOC_CXX_THROW is not defined for earlier versions of jemalloc (e.g. 3.6), causing builds to fail on some platforms. Fixing it. Closes facebook#4869
Pull Request resolved: facebook#5053

Differential Revision: D14390034

Pulled By: sagar0

fbshipit-source-id: b2b7a03cd377201ef385eb521f65bae85c558055
@Myasuka Myasuka mentioned this pull request Aug 19, 2019
Closed
Myasuka pushed a commit to Myasuka/frocksdb that referenced this pull request Aug 19, 2019
Fix build failures due to missing JEMALLOC_CXX_THROW macro (#5053)
c185d73 
Summary:
JEMALLOC_CXX_THROW is not defined for earlier versions of jemalloc (e.g. 3.6), causing builds to fail on some platforms. Fixing it. Closes #4869
Pull Request resolved: facebook/rocksdb#5053

Differential Revision: D14390034

Pulled By: sagar0

fbshipit-source-id: b2b7a03cd377201ef385eb521f65bae85c558055
Myasuka pushed a commit to Myasuka/frocksdb that referenced this pull request Aug 19, 2019
@Myasuka
Fix build failures due to missing JEMALLOC_CXX_THROW macro (#5053)
a74a347 
Summary:
JEMALLOC_CXX_THROW is not defined for earlier versions of jemalloc (e.g. 3.6), causing builds to fail on some platforms. Fixing it. Closes #4869
Pull Request resolved: facebook/rocksdb#5053

Differential Revision: D14390034

Pulled By: sagar0

fbshipit-source-id: b2b7a03cd377201ef385eb521f65bae85c558055
@Myasuka Myasuka mentioned this pull request Aug 19, 2019
Open
adamretter pushed a commit to adamretter/rocksdb that referenced this pull request Mar 7, 2020
@adamretter
Fix build failures due to missing JEMALLOC_CXX_THROW macro (facebook#…
d07167c 
…5053)

Summary:
JEMALLOC_CXX_THROW is not defined for earlier versions of jemalloc (e.g. 3.6), causing builds to fail on some platforms. Fixing it. Closes facebook#4869
Pull Request resolved: facebook#5053

Differential Revision: D14390034

Pulled By: sagar0

fbshipit-source-id: b2b7a03cd377201ef385eb521f65bae85c558055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@sagar0 sagar0 sagar0 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yiwu-arbug @sagar0 @facebook-github-bot