Update HISTORY.md to mention a bug fix #5215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miasantreble
approved these changes
Apr 18, 2019
|
It might be helpful to users to describe the impact. Can it cause corruption? If so is it localized to an SST or can it spread to the whole DB (e.g., if LSM invariants are violated)? Would it be a problem with all configurations or only certain ones? |
siying
suggested changes
Apr 18, 2019
HISTORY.md
Outdated
| @@ -17,6 +17,7 @@ | |||
| * Fix a race condition between WritePrepared::Get and ::Put with duplicate keys. | |||
| * Fix crash when memtable prefix bloom is enabled and read/write a key out of domain of prefix extractor. | |||
| * Adjust WriteBufferManager's dummy entry size to block cache from 1MB to 256KB. | |||
| * Fix a bug in GetOverlappingInputsRangeBinarySearch where a pointer should be dereferenced. | |||
There was a problem hiding this comment.
It needs to be clearer. Right now it is not very helpful to users as a part of the release note.
Also, it is under release 6.1.1, which claims to be cut in 4/9/2019. Something must be wrong somewhere.
riversand963
force-pushed
the
update_history
branch
from
7cbd604 to
080bbd1
Compare
siying
approved these changes
Apr 19, 2019
|
Can we merge it? |
|
@riversand963 ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.