Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encryption with Change Management #7020

Open
wants to merge 93 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
93 commits
Select commit Hold shift + click to select a range
f601a32
add env_encrypt2 and library_loader files and tests to build
Jun 23, 2020
385702a
make library_loader conditional on ROCKSDB_OPENSSL_AES_CTR flag
Jun 23, 2020
e464b9c
execute clang-format against the library_loader files
Jun 23, 2020
47f5ba6
another clang-format change
Jun 23, 2020
c2e7a3b
another clang-format change
Jun 23, 2020
d2f7f49
correct TARGETS file via script
Jun 23, 2020
ee5347c
use ROCKSDB_NAMESPACE instead of rocksdb
Jun 23, 2020
1fc8d3b
Merge branch 'mv-changable-encryption' of github.com:matthewvon/rocks…
Jun 23, 2020
3a99b7f
more clang-format changes
Jun 23, 2020
b611245
have test code use updated openssl api
Jun 23, 2020
261d6b9
more clang-format
Jun 23, 2020
c7e3c71
clean up library_loader_test for compile when openssl not found
Jun 23, 2020
1aebcb5
address shadow variable issue
Jun 24, 2020
767db12
Merge branch 'mv-changable-encryption' of github.com:matthewvon/rocks…
Jun 24, 2020
8d5cfa6
fix another shadow problem
Jun 24, 2020
53e36b6
remove _t suffix. remove virtual from override functions. change ca…
Jun 25, 2020
09d5080
clang-format fixes
Jun 25, 2020
ee7f477
static const std::string were not initializing before call from anoth…
Jun 25, 2020
8010570
convert from pre PosixEnv::LoadLibrary routines to use of LoadLibrary.
Jun 25, 2020
605d7f5
Merge branch 'mv-changable-encryption' of github.com:matthewvon/rocks…
Jun 25, 2020
fcca653
clang-format cleanup
Jun 25, 2020
2af6433
address PR comments concerning test of code_version and thread safety…
Jun 25, 2020
bd1f6dd
clang-format changes
Jun 25, 2020
a33e41a
reuse aes cipher contexts instead of new/free every 32 bytes
Jun 26, 2020
c4af695
clang-format changes
Jun 26, 2020
2a2ff93
clean up error message, then have error message use actual library na…
Jun 26, 2020
e2606ba
debug hack ... will be reversed
Jun 26, 2020
ef5998a
clang-format changes
Jun 26, 2020
5be10ea
add ENV_CIPHER_CTX_cleanup as alternative function for ENV_CIPHER_CTX…
Jun 29, 2020
5126bda
clang-format changes
Jun 29, 2020
7d17219
remove debug lines. change stat test to two parts to help gcc 5.4.0 …
Jun 29, 2020
f976537
Merge branch 'mv-changable-encryption' of github.com:matthewvon/rocks…
Jun 29, 2020
655fba4
add const to two EncryptionProvider methods
Jul 3, 2020
4ab57bf
add const to two EncryptionProvider methods
Jul 3, 2020
fcf9feb
address all PR comments, verify current unit tests, work INCOMPLETE .…
Jul 3, 2020
a689568
clang-format changes
Jul 3, 2020
e1e4c1c
github CI build issues addressed
Jul 3, 2020
8c81659
fix BigEndianAdd128, update EncryptedRandomRWFileV2
Jul 3, 2020
32ca640
update from facebook master
Jul 3, 2020
a905ba2
clang-format changes
Jul 3, 2020
f3b080b
there is a likely code path where valid_ is not set in EncryptedEnvV2…
Jul 7, 2020
78301f1
fix bug, update openssl usage for better performance
Jul 9, 2020
0d8775d
clang-format changes
Jul 9, 2020
ea289cc
correct error messages: seqno_pos->second.c_str is encoded binary, no…
Jul 9, 2020
2c042be
Merge branch 'mv-changable-encryption' of github.com:matthewvon/rocks…
Jul 9, 2020
179fde6
clang-format changes
Jul 9, 2020
928ed9b
use explicit casting for windows build to work
Jul 9, 2020
4861aa3
Merge branch 'mv-changable-encryption' of github.com:matthewvon/rocks…
Jul 9, 2020
0e374e7
clang-format changes
Jul 9, 2020
fe649a2
PerfContext encrypt_data_nanos and decrypt_data_nanos were never full…
Jul 9, 2020
bfc9022
Merge branch 'mv-changable-encryption' of github.com:matthewvon/rocks…
Jul 9, 2020
7409e65
clang-format changes
Jul 9, 2020
decc202
Merge branch 'master' into mv-changable-encryption
matthewvon Jul 23, 2020
d9e4c07
add a hack that attempts to force timing of static initialization in …
Jul 24, 2020
f532743
clang-format changes
Jul 24, 2020
9186deb
correct two unchecked Status object errors: remove from env_posix.cc …
Jul 24, 2020
533eaaf
clang-format changes
Jul 24, 2020
fa7efc6
revert blind attempt to correct an unused Status value error.
Jul 26, 2020
69de914
fix UBSAN test error by initializing libCrypto in EncryptedEnvV2 obje…
Jul 26, 2020
30cc0aa
remove CipherStreamWrapper test class since no longer needed and caus…
Jul 26, 2020
46b2bc6
Merge branch 'mv-changable-encryption' of github.com:matthewvon/rocks…
Jul 26, 2020
929cddd
rename of files and classes. env_encrypt2 to env_openssl
Aug 3, 2020
f636ef4
clang-format changes
Aug 3, 2020
6a2d548
Merge branch 'master' into mv-changable-encryption
matthewvon Aug 3, 2020
40f6c0b
reuse of Default when user asks for New was a really bad idea.
Aug 8, 2020
0fcaa7d
Merge branch 'mv-changable-encryption' of github.com:matthewvon/rocks…
Aug 8, 2020
3005402
address all PR issues except GetCrypto.
Aug 9, 2020
178cf31
implement requested GetCrypto via std::call_once process.
Aug 9, 2020
5db9879
add factory functions to the three main objects in env_openssl.h
Aug 9, 2020
ac523ae
whitespace change to force new CI run
Aug 9, 2020
cda48e7
env_openssl_test would crash on OSX with static keylock. Made it a m…
Aug 14, 2020
a9135ca
correct key_lock to key_lock_ since now a member variable
Aug 14, 2020
5180b7b
WIP, safety check-in and update from rocksdb master, DOES NOT COMPILE
matthewvon Oct 19, 2020
1b0c99c
safety check-in ... does not build
matthewvon Nov 3, 2020
67bc3b8
Merge branch 'master' into mv-changable-encryption
matthewvon Nov 3, 2020
97a767b
finish conversion to new EncryptionProvider model
matthewvon Nov 4, 2020
a1a61eb
add missing override marker to TEST_Initialize
matthewvon Nov 4, 2020
9e903c5
remove obsolete kCTROpenSSL declare/define
matthewvon Nov 4, 2020
b55ec0e
must make OpenSSLEncryptionProvider a compile option within env_encry…
matthewvon Nov 4, 2020
9767058
update NormalizingEnvWrapper to properly delete encryptionEnv
matthewvon Nov 4, 2020
8e2a09c
oops ... needed clang-format
matthewvon Nov 5, 2020
3dfa896
guessing a circleCI test was failing due to overlapped test execution?
matthewvon Nov 5, 2020
7d90321
correct formatting
matthewvon Nov 5, 2020
fcf3737
output from python3 buckifier/buckify_rocksdb.py
matthewvon Nov 5, 2020
019cf6b
forgot to use lock when adding key to provider. also cleaned out som…
matthewvon Nov 5, 2020
5dc2a57
clang-format wanted one blank line removed
matthewvon Nov 5, 2020
aaa8e16
address PR comments. Not complete.
matthewvon Nov 22, 2020
e501208
remove util/library_loader. merge key components into env_openssl.
matthewvon Nov 23, 2020
bde3d5c
forgot to run clang-format. reversed testing change to CMakeLists.txt
matthewvon Nov 23, 2020
21a89e8
add option for AES encryption via OpenSSL dynamic library
matthewvon Dec 21, 2020
3f12534
clean up unused variable warning when dynamic library support not com…
matthewvon Dec 21, 2020
690ce77
stop compile of OpenSSL AES if DynamicLibrary disabled
matthewvon Dec 22, 2020
97df484
clang-format env_openssl.cc
matthewvon Dec 22, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
output from python3 buckifier/buckify_rocksdb.py
matthewvon committed Nov 5, 2020
commit fcf373747d5550a8297d1cf304c84fe4c86e9037
2 changes: 2 additions & 0 deletions TARGETS
Original file line number Diff line number Diff line change
@@ -501,6 +501,7 @@ cpp_library(
"env/env_chroot.cc",
"env/env_encryption.cc",
"env/env_hdfs.cc",
"env/env_openssl.cc",
"env/env_posix.cc",
"env/file_system.cc",
"env/file_system_tracer.cc",
@@ -627,6 +628,7 @@ cpp_library(
"util/dynamic_bloom.cc",
"util/file_checksum_helper.cc",
"util/hash.cc",
"util/library_loader.cc",
"util/murmurhash.cc",
"util/random.cc",
"util/rate_limiter.cc",