More backup/restore stress test fixes #7361
Conversation
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| std::string restore_dir = FLAGS_db + "/.restore" + ToString(thread->tid); | ||
| // Reasons for this: | ||
| // * Free up disk space ASAP after crash & restart | ||
| // * Attempting to restore from backup from prior invocation could fail |
There was a problem hiding this comment.
Just wondering, do you have an example of such an option?
There was a problem hiding this comment.
Here's the failure I'm trying to fix:
Failure in DB::Open in backup/restore with: Not implemented: WritePrepared/WriteUnprepared txn tag when write_after_commit_ is enabled (in default WriteCommitted mode). If it is not due to corruption, the WAL must be emptied before changing the WritePolicy.
After private chat, my diagnosis is a bit wrong. We can't (necessarily) use vanilla DB::Open when blobdb or txndb are enabled. Revision coming
Summary: (a) Missed a case in updating handling of rand_keys (b) Only opening restored db with DB::Open so don't (yet) attempt to open restored BlobDB or TransactionDB. Test Plan: better than being broken
pdillinger
force-pushed
the
stress_test_backup2
branch
from
7637d9f to
1dba8e8
Compare
|
@pdillinger has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@pdillinger merged this pull request in e314935. |
Summary: (a) Missed a case in updating handling of rand_keys (b) Only opening restored db with DB::Open so don't (yet) attempt to open restored BlobDB or TransactionDB. Pull Request resolved: facebook#7361 Test Plan: better than being broken Reviewed By: ajkr Differential Revision: D23592570 Pulled By: pdillinger fbshipit-source-id: dd1d999bcc0c852ee77cb6041964ec4abc0fd4fd
Summary: (a) Missed a case in updating handling of rand_keys
(b) Only opening restored db with DB::Open so don't (yet)
attempt to open restored BlobDB or TransactionDB.
Test Plan: better than being broken