Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a missing bug fix in HISTORY.md #7549

Closed
wants to merge 3 commits into from
Closed

Add a missing bug fix in HISTORY.md #7549

wants to merge 3 commits into from

Conversation

jay-zhuang
Copy link
Contributor

No description provided.

facebook-github-bot
facebook-github-bot reviewed Oct 13, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jay-zhuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ajkr
ajkr reviewed Oct 13, 2020
View reviewed changes
Copy link
Contributor

@ajkr ajkr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to add the note on 6.14.fb branch as well? I usually just append it to the "Unreleased" section and say "Since 6.14, <bug fix note>". But if you want to try keeping the "6.14" section on 6.14.fb and master branches in sync, we can try that too.

@jay-zhuang
Copy link
Contributor Author

Do you plan to add the note on 6.14.fb branch as well? I usually just append it to the "Unreleased" section and say "Since 6.14, ". But if you want to try keeping the "6.14" section on 6.14.fb and master branches in sync, we can try that too.

I see. I thought Since x.xx means the bug happens since version x.xx. Will just use that.

ajkr
ajkr approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot
facebook-github-bot reviewed Oct 14, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jay-zhuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang merged this pull request in c87c3a4.

codingrhythm pushed a commit to SafetyCulture/rocksdb that referenced this pull request Mar 5, 2021
@jay-zhuang @codingrhythm
Add a missing bug fix in HISTORY.md (facebook#7549)
ebded31 
Summary: Pull Request resolved: facebook#7549

Reviewed By: ajkr, zhichao-cao

Differential Revision: D24292032

Pulled By: jay-zhuang

fbshipit-source-id: 0442283386ae20d10410a8d013a431d7cd282b22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ajkr ajkr ajkr approved these changes

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jay-zhuang @facebook-github-bot @ajkr