Trace MultiGet Keys and CF_IDs to the trace file #8421
Conversation
|
@zhichao-cao has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
| @@ -1880,6 +1880,16 @@ std::vector<Status> DBImpl::MultiGet( | |||
| } | |||
| #endif // NDEBUG | |||
|
|
|||
| if (tracer_) { | |||
There was a problem hiding this comment.
There are a few different MultiGet overloaded APIs. We should trace all of them.
|
@zhichao-cao has updated the pull request. You must reimport the pull request before landing. |
|
@zhichao-cao has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sure, will update soon. |
zhichao-cao
force-pushed
the
trace_multiget
branch
from
15b403a to
b39a15d
Compare
|
@zhichao-cao has updated the pull request. You must reimport the pull request before landing. |
|
@zhichao-cao has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@zhichao-cao merged this pull request in 82a70e1. |
Tracing the MultiGet information including timestamp, keys, and CF_IDs to the trace file for analyzing and replay.
test plan: make check, add test to trace_analyzer_test