-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate WriteBatch.remove() and use the new style delete() #9256
Conversation
@@ -85,6 +99,19 @@ public void delete(ColumnFamilyHandle columnFamilyHandle, byte[] key) | |||
delete(nativeHandle_, key, key.length, columnFamilyHandle.nativeHandle_); | |||
} | |||
|
|||
@Override | |||
public void delete(ByteBuffer key) throws RocksDBException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you mark the parameters as final
please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@javeme Can you run |
c1b3043
to
d5be8b5
Compare
d5be8b5
to
c41688a
Compare
@jay-zhuang @mrambacher Another one to merge please |
@jay-zhuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@javeme has updated the pull request. You must reimport the pull request before landing. |
@jay-zhuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
No description provided.