Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libs for RocksJava Static build #9304

Closed
wants to merge 4 commits into from
Closed

Update libs for RocksJava Static build #9304

wants to merge 4 commits into from

Conversation

adamretter
Copy link
Collaborator

Updates ZStd and Snappy to the latest versions.

mrambacher
mrambacher approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@mrambacher mrambacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@facebook-github-bot
Copy link
Contributor

@mrambacher has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jay-zhuang
Copy link
Contributor

Is the CI failure related to this change?

@adamretter
Copy link
Collaborator Author

@jay-zhuang Ooof! Yes, it looks like a problem with compiling Snappy on that specific platform, I will have to investigate:

/Users/distiller/project/snappy-1.1.9/snappy.cc:1033:36: error: invalid output constraint '=@ccz' in asm
      : [tag_type] "+r"(tag_type), "=@ccz"(is_literal));
                                   ^
1 error generated.
make[4]: *** [CMakeFiles/snappy.dir/snappy.cc.o] Error 1
make[3]: *** [CMakeFiles/snappy.dir/all] Error 2
make[2]: *** [all] Error 2
make[1]: *** [libsnappy.a] Error 2

@facebook-github-bot
Copy link
Contributor

@adamretter has updated the pull request. You must reimport the pull request before landing.

ajkr
ajkr requested changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI shows checksum mismatches. Do they need to be updated?

@adamretter
Copy link
Collaborator Author

adamretter commented Feb 21, 2022 •
edited
Loading

@ajkr It is failing because downloading the artifacts yields HTTP 404 Not Found.

It looks like @jay-zhuang updated the CircleCI config to override the URLs for the download of the artifacts.
@jay-zhuang Would you be able to upload the latest libraries please?

@jay-zhuang
Copy link
Contributor

I think there's failure even build locally (without using binaries from s3), please take a look:

/home/zjay/ws/rocksdb/snappy-1.1.9/snappy.cc:1017:8: warning: always_inline function might not be inlinable [-Wattributes]
 1017 | size_t AdvanceToNextTag(const uint8_t** ip_p, size_t* tag) {
      |        ^~~~~~~~~~~~~~~~
/home/zjay/ws/rocksdb/snappy-1.1.9/snappy.cc: In function 'std::pair<const unsigned char*, long int> snappy::DecompressBranchless(const uint8_t*, const uint8_t*, ptrdiff_t, T, ptrdiff_t) [with T = char*]':
/home/zjay/ws/rocksdb/snappy-1.1.9/snappy.cc:1017:8: error: inlining failed in call to always_inline 'size_t snappy::AdvanceToNextTag(const uint8_t**, size_t*)': function body can be overwritten at link time
/home/zjay/ws/rocksdb/snappy-1.1.9/snappy.cc:1097:43: note: called from here
 1097 |         size_t tag_type = AdvanceToNextTag(&ip, &tag);
      |                           ~~~~~~~~~~~~~~~~^~~~~~~~~~~

zstd and sanppy binaries are uploaded.

@facebook-github-bot
Copy link
Contributor

@adamretter has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@adamretter has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@adamretter has updated the pull request. You must reimport the pull request before landing.

@jowlyzhang
Copy link
Contributor

I have uploaded the latest versions for these libraries. Can you rerun all the failing tests? Thanks!

jowlyzhang
jowlyzhang reviewed Oct 2, 2023
View reviewed changes
Makefile Outdated
ZSTD_VER ?= 1.4.9
ZSTD_SHA256 ?= acf714d98e3db7b876e5b540cbf6dee298f60eb3c0723104f6d3f065cd60d6a8
ZSTD_VER ?= 1.5.5
ZSTD_SHA256 ?= 98e9c3d949d1b924e28e01eccb7deed865eefebf25c2f21c702e5cd5b63b85e1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems to have been updated to 9c4396cc829cfae319a6e2615202e82aad41372073482fce286fac78646d3ee4

@jowlyzhang
Copy link
Contributor

Snappy still have some build errors.

@facebook-github-bot
Copy link
Contributor

@adamretter has updated the pull request. You must reimport the pull request before landing.

@jowlyzhang
Copy link
Contributor

Looks like snappy 1.1.9 has some compilation errors too.

@facebook-github-bot
Copy link
Contributor

@adamretter has updated the pull request. You must reimport the pull request before landing.

@adamretter
Copy link
Collaborator Author

@jowlyzhang Hmm... for the time being I have removed the Snappy updates from this PR.

@facebook-github-bot
Copy link
Contributor

@adamretter has updated the pull request. You must reimport the pull request before landing.

@adamretter adamretter mentioned this pull request Oct 20, 2023
Closed
@facebook-github-bot
Copy link
Contributor

@adamretter has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@adamretter has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cbi42 merged this pull request in d7567d5.

@adamretter
Copy link
Collaborator Author

@cbi42 I am not seeing it also in the 8.7.fb branch yet?

cbi42 pushed a commit that referenced this pull request Oct 20, 2023
@adamretter @cbi42
Update libs for RocksJava Static build (#9304)
f86d198 
Summary:
Updates ZStd and Snappy to the latest versions.

Pull Request resolved: #9304

Reviewed By: ajkr

Differential Revision: D33176708

Pulled By: cbi42

fbshipit-source-id: eb50db50557c433e19fcc7c2874329d1d6cba93f
@cbi42
Copy link
Member

cbi42 commented Oct 20, 2023

@cbi42 I am not seeing it also in the 8.7.fb branch yet?

Yeah sorry, I just pushed it to 8.7.fb.

ajkr pushed a commit that referenced this pull request Oct 20, 2023
@adamretter @ajkr
Update libs for RocksJava Static build (#9304)
82e7262 
Summary:
Updates ZStd and Snappy to the latest versions.

Pull Request resolved: #9304

Reviewed By: ajkr

Differential Revision: D33176708

Pulled By: cbi42

fbshipit-source-id: eb50db50557c433e19fcc7c2874329d1d6cba93f
@adamretter adamretter mentioned this pull request Oct 24, 2023
Closed
@adamretter
Copy link
Collaborator Author

@cbi42 Somehow there was a bad checksum in this PR, sorry about that! - I have addressed that in this new PR #12005

facebook-github-bot pushed a commit that referenced this pull request Oct 31, 2023
@adamretter @facebook-github-bot
Fix the ZStd checksum (#12005)
e0c45c1 
Summary:
Somehow we had the wrong checksum when validating the ZStd 1.5.5 download for RocksJava in the previous Pull Request - #9304. This PR fixes that.

Pull Request resolved: #12005

Reviewed By: jaykorean

Differential Revision: D50840338

Pulled By: cbi42

fbshipit-source-id: 8a92779d3bef013d812eecb89aaaf33fc73991ec
cbi42 pushed a commit that referenced this pull request Oct 31, 2023
@adamretter @cbi42
Fix the ZStd checksum (#12005)
596718b 
Summary:
Somehow we had the wrong checksum when validating the ZStd 1.5.5 download for RocksJava in the previous Pull Request - #9304. This PR fixes that.

Pull Request resolved: #12005

Reviewed By: jaykorean

Differential Revision: D50840338

Pulled By: cbi42

fbshipit-source-id: 8a92779d3bef013d812eecb89aaaf33fc73991ec
hx235 pushed a commit that referenced this pull request Nov 1, 2023
@adamretter @hx235
Fix the ZStd checksum (#12005)
54bb018 
Summary:
Somehow we had the wrong checksum when validating the ZStd 1.5.5 download for RocksJava in the previous Pull Request - #9304. This PR fixes that.

Pull Request resolved: #12005

Reviewed By: jaykorean

Differential Revision: D50840338

Pulled By: cbi42

fbshipit-source-id: 8a92779d3bef013d812eecb89aaaf33fc73991ec
@igorcanadi igorcanadi mentioned this pull request Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jowlyzhang jowlyzhang jowlyzhang left review comments

@ajkr ajkr ajkr requested changes

@mrambacher mrambacher mrambacher approved these changes

@jay-zhuang jay-zhuang Awaiting requested review from jay-zhuang

Assignees
No one assigned
Labels
CLA Signed java-api Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@adamretter @facebook-github-bot @jay-zhuang @jowlyzhang @cbi42 @mrambacher @ajkr