Skip to content

Commit

Permalink
getdeps: remove test-getdeps from Sapling manifest (#4373)
Browse files Browse the repository at this point in the history
Summary:
X-link: facebookincubator/velox#4373

We are now planning to remove the Sapling getdeps build since Sapling
doesn't use it for open source anyway. The EdenFS getdeps build will adapt one
way or another.

This diff only remove the test step of the Sapling getdeps, which is failing
now. Will remove the entire Sapling manifest the following diff.

Reviewed By: quark-zju

Differential Revision: D44233463

fbshipit-source-id: c29419ab316fb1d0c3131d00b2fe3b4e3bb879e6
  • Loading branch information
zzl0 authored and facebook-github-bot committed Mar 21, 2023
1 parent e6a0979 commit badf6d1
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
3 changes: 0 additions & 3 deletions build/fbcode_builder/manifests/sapling
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@ getdepsbuild
[make.install_args]
install-getdeps

[make.test_args]
test-getdeps

[shipit.pathmap]
fbcode/configerator/structs/scm/hg = configerator/structs/scm/hg
fbcode/configerator/structs/scm/hg/public_autocargo = configerator/structs/scm/hg
Expand Down
6 changes: 0 additions & 6 deletions eden/scm/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,6 @@ install-getdeps: getdepsbuild
GETDEPS_BUILD=1 $(shell $(PYTHON3) contrib/pick_python.py $(PYTHON3)) \
setup.py $(PURE) install --root="$(DESTDIR)/" --prefix="$(PREFIX)" --install-lib="$(PREFIX)/bin" --force

test-getdeps: install-getdeps
# Run one test to check the binary is minimally good as will be used later in Mononoke getdeps tests
# Running all the tests requires a bit of filtering to run the good set (or deleting flaky ones)
cd tests && PYTHON_SYS_EXECUTABLE=$(shell $(PYTHON3) contrib/pick_python.py $(PYTHON3)) \
$(shell $(PYTHON3) contrib/pick_python.py $(PYTHON3)) run-tests.py -j1 --getdeps-build --with-hg="$(PREFIX)/bin/$(HGNAME)" test-status.t test-convert.t

check: tests

.PHONY: tests
Expand Down

0 comments on commit badf6d1

Please sign in to comment.