getdeps: add xxhash ubuntu and homebrew packages, fix actions generation and regenerate #966
+50
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Oct 13, 2024
…ion and regenerate (facebook#966) Summary: EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check where if tests not run it wouldn't generate system dependency usage. Fix it and regenerate Test Plan: Build locally on ubuntu-22.04 toolbox to repro issue, its broken, ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden ``` Install the packages: ``` ./build/fbcode_builder/getdeps.py install-system-deps --recursive eden ``` Run again, it builds: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden ``` Regenerate the github workflow: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --no-tests --free-up-disk --os-type=linux --src-dir=. --output-dir=.github/workflows --job-name "EdenFS " --job-file-prefix=edenfs_ eden --num-jobs=8 --project-install-prefix sapling:/usr/local ``` Differential Revision: D64302134 Pulled By: ahornby
|
@ahornby has updated the pull request. You must reimport the pull request before landing. |
|
This pull request was exported from Phabricator. Differential Revision: D64302134 |
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Oct 13, 2024
…ion and regenerate (facebook#966) Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check where if tests not run it wouldn't generate system dependency usage. Fix it and regenerate Test Plan: Build locally on ubuntu-22.04 toolbox to repro issue, its broken, ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden ``` Install the packages: ``` ./build/fbcode_builder/getdeps.py install-system-deps --recursive eden ``` Run again, it builds: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden ``` Regenerate the github workflow: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --no-tests --free-up-disk --os-type=linux --src-dir=. --output-dir=.github/workflows --job-name "EdenFS " --job-file-prefix=edenfs_ eden --num-jobs=8 --project-install-prefix sapling:/usr/local ``` Differential Revision: D64302134 Pulled By: ahornby
|
@ahornby has updated the pull request. You must reimport the pull request before landing. |
|
This pull request was exported from Phabricator. Differential Revision: D64302134 |
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Oct 13, 2024
…ion and regenerate (facebook#966) Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check where if tests not run it wouldn't generate system dependency usage. Fix it and regenerate Test Plan: Build locally on ubuntu-22.04 toolbox to repro issue, its broken, ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden ``` Install the packages: ``` ./build/fbcode_builder/getdeps.py install-system-deps --recursive eden ``` Run again, it builds: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden ``` Regenerate the github workflow: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --no-tests --free-up-disk --os-type=linux --src-dir=. --output-dir=.github/workflows --job-name "EdenFS " --job-file-prefix=edenfs_ eden --num-jobs=8 --project-install-prefix sapling:/usr/local ``` Differential Revision: D64302134 Pulled By: ahornby
|
This pull request was exported from Phabricator. Differential Revision: D64302134 |
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Oct 13, 2024
…ion and regenerate (facebook#966) Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check where if tests not run it wouldn't generate system dependency usage. Fix it and regenerate Test Plan: Build locally on ubuntu-22.04 toolbox to repro issue, its broken, ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden ``` Install the packages: ``` ./build/fbcode_builder/getdeps.py install-system-deps --recursive eden ``` Run again, it builds: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden ``` Regenerate the github workflow: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --no-tests --free-up-disk --os-type=linux --src-dir=. --output-dir=.github/workflows --job-name "EdenFS " --job-file-prefix=edenfs_ eden --num-jobs=8 --project-install-prefix sapling:/usr/local ``` Differential Revision: D64302134 Pulled By: ahornby
|
@ahornby has updated the pull request. You must reimport the pull request before landing. |
|
This pull request was exported from Phabricator. Differential Revision: D64302134 |
ahornby
added a commit
to ahornby/sapling
that referenced
this pull request
Oct 13, 2024
…ion and regenerate (facebook#966) Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check where if tests not run it wouldn't generate system dependency usage. Fix it and regenerate Test Plan: Build locally on ubuntu-22.04 toolbox to repro issue, its broken, ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden ``` Install the packages: ``` ./build/fbcode_builder/getdeps.py install-system-deps --recursive eden ``` Run again, it builds: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden ``` Regenerate the github workflow: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --no-tests --free-up-disk --os-type=linux --src-dir=. --output-dir=.github/workflows --job-name "EdenFS " --job-file-prefix=edenfs_ eden --num-jobs=8 --project-install-prefix sapling:/usr/local ``` Differential Revision: D64302134 Pulled By: ahornby
|
This pull request was exported from Phabricator. Differential Revision: D64302134 |
|
@ahornby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…ion and regenerate (facebook#966) Summary: EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate Test Plan: Build locally on ubuntu-22.04 toolbox to repro issue, its broken, ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden ``` Install the packages: ``` ./build/fbcode_builder/getdeps.py install-system-deps --recursive eden ``` Run again, it builds: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. eden ``` Regenerate the github workflow: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --no-tests --free-up-disk --os-type=linux --src-dir=. --output-dir=.github/workflows --job-name "EdenFS " --job-file-prefix=edenfs_ eden --num-jobs=8 --project-install-prefix sapling:/usr/local ``` Differential Revision: D64302134 Pulled By: ahornby
|
@ahornby has updated the pull request. You must reimport the pull request before landing. |
|
This pull request was exported from Phabricator. Differential Revision: D64302134 |
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Oct 14, 2024
…ion and regenerate Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate X-link: facebook/sapling#966 Reviewed By: genevievehelsel Differential Revision: D64302134 Pulled By: ahornby fbshipit-source-id: 3384dab4f31e202881310e2b5369bb23fb533a1b
facebook-github-bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Oct 14, 2024
…ion and regenerate Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate X-link: facebook/sapling#966 Reviewed By: genevievehelsel Differential Revision: D64302134 Pulled By: ahornby fbshipit-source-id: 3384dab4f31e202881310e2b5369bb23fb533a1b
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Oct 14, 2024
…ion and regenerate Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate X-link: facebook/sapling#966 Reviewed By: genevievehelsel Differential Revision: D64302134 Pulled By: ahornby fbshipit-source-id: 3384dab4f31e202881310e2b5369bb23fb533a1b
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Oct 14, 2024
…ion and regenerate Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate X-link: facebook/sapling#966 Reviewed By: genevievehelsel Differential Revision: D64302134 Pulled By: ahornby fbshipit-source-id: 3384dab4f31e202881310e2b5369bb23fb533a1b
facebook-github-bot
pushed a commit
to facebookexperimental/moxygen
that referenced
this pull request
Oct 14, 2024
…ion and regenerate Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate X-link: facebook/sapling#966 Reviewed By: genevievehelsel Differential Revision: D64302134 Pulled By: ahornby fbshipit-source-id: 3384dab4f31e202881310e2b5369bb23fb533a1b
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Oct 14, 2024
…ion and regenerate Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate X-link: facebook/sapling#966 Reviewed By: genevievehelsel Differential Revision: D64302134 Pulled By: ahornby fbshipit-source-id: 3384dab4f31e202881310e2b5369bb23fb533a1b
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Oct 14, 2024
…ion and regenerate Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate X-link: facebook/sapling#966 Reviewed By: genevievehelsel Differential Revision: D64302134 Pulled By: ahornby fbshipit-source-id: 3384dab4f31e202881310e2b5369bb23fb533a1b
facebook-github-bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Oct 14, 2024
…ion and regenerate Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate X-link: facebook/sapling#966 Reviewed By: genevievehelsel Differential Revision: D64302134 Pulled By: ahornby fbshipit-source-id: 3384dab4f31e202881310e2b5369bb23fb533a1b
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Oct 14, 2024
…ion and regenerate Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate X-link: facebook/sapling#966 Reviewed By: genevievehelsel Differential Revision: D64302134 Pulled By: ahornby fbshipit-source-id: 3384dab4f31e202881310e2b5369bb23fb533a1b
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Oct 14, 2024
…ion and regenerate Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate X-link: facebook/sapling#966 Reviewed By: genevievehelsel Differential Revision: D64302134 Pulled By: ahornby fbshipit-source-id: 3384dab4f31e202881310e2b5369bb23fb533a1b
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Oct 14, 2024
…ion and regenerate Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate X-link: facebook/sapling#966 Reviewed By: genevievehelsel Differential Revision: D64302134 Pulled By: ahornby fbshipit-source-id: 3384dab4f31e202881310e2b5369bb23fb533a1b
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Oct 14, 2024
…ion and regenerate Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate X-link: facebook/sapling#966 Reviewed By: genevievehelsel Differential Revision: D64302134 Pulled By: ahornby fbshipit-source-id: 3384dab4f31e202881310e2b5369bb23fb533a1b
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Oct 14, 2024
…ion and regenerate Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate X-link: facebook/sapling#966 Reviewed By: genevievehelsel Differential Revision: D64302134 Pulled By: ahornby fbshipit-source-id: 3384dab4f31e202881310e2b5369bb23fb533a1b
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Oct 14, 2024
…ion and regenerate Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate X-link: facebook/sapling#966 Reviewed By: genevievehelsel Differential Revision: D64302134 Pulled By: ahornby fbshipit-source-id: 3384dab4f31e202881310e2b5369bb23fb533a1b
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Oct 14, 2024
…ion and regenerate Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate X-link: facebook/sapling#966 Reviewed By: genevievehelsel Differential Revision: D64302134 Pulled By: ahornby fbshipit-source-id: 3384dab4f31e202881310e2b5369bb23fb533a1b
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Oct 14, 2024
…ion and regenerate Summary: X-link: facebookincubator/zstrong#1010 EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838 Add package mappings to the xxhash manifest When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate X-link: facebook/sapling#966 Reviewed By: genevievehelsel Differential Revision: D64302134 Pulled By: ahornby fbshipit-source-id: 3384dab4f31e202881310e2b5369bb23fb533a1b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
EdenFS build on github CI was failing with missing xxhash include: https://github.com/facebook/sapling/actions/runs/11311478649/job/31457761727#step:108:3838
Add package mappings to the xxhash manifest
When I went to regenerate the github actions found I'd previously introduced a bug in the actions generation with a mis-merged run_tests check. Fix it and regenerate
Test Plan:
Build locally on ubuntu-22.04 toolbox to repro issue, its broken,
Install the packages:
Run again, it builds:
Regenerate the github workflow: