Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sapling: fix threading cyclic import error when calling traceback #976

Closed
wants to merge 1 commit into from

Commits on Oct 27, 2024

  1. sapling: fix threading cyclic import error when calling traceback

    Summary:
    
    Test Plan:
    
    Before:
    ```
    ./build/fbcode_builder/getdeps.py --allow-system-packages test --src-dir=. sapling --num-jobs=32 --filter test-fb-ext-grpcheck.t --retry 0
    ...
    -  You should be in devs group.
    +  unknown python exception <class 'AttributeError'> Some(AttributeError("partially initialized module 'threading' has no attribute 'RLock' (most likely due to a circular import)")) (no-eol)
    +  [1]
    
    ```
    
    After:
    ```
    ----------------------------------------------------------------------
    # Ran 1 tests, 0 skipped, 0 failed.
    passed on try 0
    ```
    ahornby committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    8b9858e View commit details
    Browse the repository at this point in the history