Remove an error context

Summary: Removing an anyhow context. The error message calls out the term that's causing the issue and prints the erroranous line. I believe it should be pretty obvious that the error is on RHS.

Reviewed By: JakobDegen

Differential Revision: D63057184

fbshipit-source-id: c904b323e91cfd8f81f0502f93d81676dd286c3e

starlark/src/typing/tests/golden/bit_or_return_int.golden

@@ -18,15 +18,9 @@ Approximation: Unknown type = "Span { begin: Pos(30), end: Pos(34) }"
 Compiler typechecker (eval):
 Compiler typechecker and eval results mismatch.
 
-error: converting RHS to type
+error: Type `3` is not a valid type annotation
  --> filename:2:8
   |
 2 | test = int | 3
   |        ^^^^^^^
   |
-
-
-converting RHS to type
-
-Caused by:
-    Type `3` is not a valid type annotation

starlark/src/typing/tests/golden/test_bit_or_with_load.golden

@@ -18,15 +18,9 @@ Approximation: Unknown type = "Span { begin: Pos(57), end: Pos(61) }"
 Compiler typechecker (eval):
 Compiler typechecker and eval results mismatch.
 
-error: converting RHS to type
+error: String literals are not allowed in type expressions: `"test"`
  --> filename:3:8
   |
 3 | test = int | foo()
   |        ^^^^^^^^^^^
   |
-
-
-converting RHS to type
-
-Caused by:
-    String literals are not allowed in type expressions: `"test"`

starlark/src/values/typing/macro_refs.rs

@@ -16,9 +16,6 @@
  */
 
 #![doc(hidden)]
-
-use anyhow::Context;
-
 use crate::values::typing::type_compiled::compiled::TypeCompiled;
 use crate::values::Heap;
 use crate::values::StarlarkValue;
@@ -44,6 +41,6 @@ pub fn starlark_value_bit_or_for_type<'v, S: StarlarkValue<'v>>(
         )));
     };
     let this = TypeCompiled::from_ty(&this, heap);
-    let other = TypeCompiled::new(other, heap).context("converting RHS to type")?;
+    let other = TypeCompiled::new(other, heap)?;
     Ok(TypeCompiled::type_any_of_two(this, other, heap).to_inner())
 }