Fix hover info & go to definition for named parameters #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows requesting a list/tree of symbols in the current document.
The following items are currently exposed:
- `load` statements:
- The module path
- The loaded symbol names
- `def` statements:
- The function node
- Argument names
- Closures, when assigned to a named variable
- Structs (calls to `struct`), when assigned to a named variable
- Build system targets (function calls containing a `name` argument)
Allow passing in an `--eager` flag to the LSP to make it eagerly load all relevant files in the workspace. When this flag is provided, files are not removed from the `last_valid_parse` cache when they are closed. In addition, this flag enables the LSP to provide workspace symbol information.
…}` and `starlark_lsp::symbol::{Symbol, SymbolKind}`
facebook-github-bot
added
the
CLA Signed
MaartenStaa
force-pushed
the
named-parameter-hover-info
branch
from
b45fa60
to
115e8a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #117
Previously, hovering over or triggering "go to definition" for named parameters in function calls did nothing. This PR makes sure the required information is exposed, so both of these work as expected.
Example from
starlark_syntax/testcases/parse/aspect.star(after adding function documentation—otherwise only go to definition does anything):