Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a WASM/JS example #129

Closed
wants to merge 1 commit into from
Closed

Add a WASM/JS example #129

wants to merge 1 commit into from

Conversation

ndmitchell
Copy link
Contributor

@ndmitchell ndmitchell commented Aug 25, 2024

Based on the code in #109 (comment), with a few minor changes to make it work with stable and work for types that aren't string. Plus a slightly nicer HTML page where you can edit the input.

image

Credit for most of the code goes to @aschleck.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2024
Based on the code in #109 (comment), with a few minor changes to make it work with stable and work for types that aren't string. Plus a slightly nicer HTML page where you can edit the input.
@facebook-github-bot
Copy link
Contributor

@ndmitchell has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ndmitchell
Copy link
Contributor Author

The segfault is coming from having the function named malloc. I'll fix that up on the Meta side and reexport there.

@facebook-github-bot
Copy link
Contributor

@ndmitchell merged this pull request in 4d32658.

facebook-github-bot pushed a commit to facebook/buck2 that referenced this pull request Aug 28, 2024
Summary:
Based on the code in facebook/starlark-rust#109 (comment), with a few minor changes to make it work with stable and work for types that aren't string. Plus a slightly nicer HTML page where you can edit the input.

![image](https://github.com/user-attachments/assets/cc5a1f42-8e25-4284-9d9c-9ccffdeab318)

Credit for most of the code goes to aschleck.

X-link: facebook/starlark-rust#129

Reviewed By: stepancheg

Differential Revision: D61774902

Pulled By: ndmitchell

fbshipit-source-id: 4babe21de199f194be3405cd7e22b543a3e9169d
@ndmitchell ndmitchell mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants