Parameter autocomplete improvements #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, parameter type autocomplete would be offered when no parameters were typed yet (`foo(|)`), but not when adding a second (or third, ...) parameters (`foo(bar, |)`).
e.g. in a function call, if you type a comma you would get the completion options for parameter names and such, but then if you typed a space you would lose the autocomplete, and would have to manually trigger it again.
facebook-github-bot
added
the
CLA Signed
|
All looks good - importing with the intention of merging as is. I'll make the single line comment addition |
ndmitchell
approved these changes
Aug 29, 2023
| @@ -60,6 +61,7 @@ pub enum AutocompleteType { | |||
| Parameter { | |||
| function_name: String, | |||
| function_name_span: ResolvedSpan, | |||
| previously_used_named_parameters: Vec<String>, | |||
There was a problem hiding this comment.
The name is pretty clear, but perhaps just one sentence that they were already used in the function already
|
@ndmitchell has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@ndmitchell merged this pull request in c86e26b. |
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Aug 30, 2023
Summary: Some autocomplete improvements aimed at typing parameters: - Correctly offer parameter completion options when typing a new parameter after the first one. - Omit already used parameter names as options. - Re-offer completion when typing a space after a comma in a function call (and other such cases). X-link: facebook/starlark-rust#81 Reviewed By: stepancheg Differential Revision: D48782136 Pulled By: ndmitchell fbshipit-source-id: e64faca0292f1722106beb503801d880b4c64be4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some autocomplete improvements aimed at typing parameters: