feat: graceful parsing of load statements
#83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't produce a parse error on `load` statements with only one argument, issue an error to the parser state instead. This allow the LSP to correctly detect when the cursor is inside the first argument to a `load` statement, and offer autocomplete options accordingly.
facebook-github-bot
added
the
CLA Signed
|
Thanks for the diff. Looks good to me, but I'll let @stepancheg review here too, then we can import/merge it. |
|
Looks good. |
|
@stepancheg has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@stepancheg merged this pull request in 0e5192f. |
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Aug 29, 2023
Summary: Don't produce a parse error on `load` statements with only one argument, issue an error to the parser state instead. This allow the LSP to correctly detect when the cursor is inside the first argument to a `load` statement, and offer autocomplete options accordingly (see also facebook/starlark-rust#82). X-link: facebook/starlark-rust#83 Reviewed By: ndmitchell Differential Revision: D48797898 Pulled By: stepancheg fbshipit-source-id: de47f8d27b3eeca20231b460a141cb08c684079a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't produce a parse error on
loadstatements with only one argument, issue an error to the parser state instead. This allow the LSP to correctly detect when the cursor is inside the first argument to aloadstatement, and offer autocomplete options accordingly (see also #82).