-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: implement vite plugin #66
base: main
Are you sure you want to change the base?
Conversation
Maybe you can make it draft since unit test is not ready yet. @nonzzz |
Thanks for this PR! Vite support is one of the most requested features already. Other than the missing unit tests, I don't think it solves the problem of generating CSS bundles in dev mode? If we can make frameworks like Qwik and Astro work with this plugin, we should include examples for those as well. |
Thanks a lot for this effort! I implemented an integration for astro: astro-stylex. Would love to see this land so it can hopefully be made even better . |
Great stuff @lilnasy ! |
I worked with a friend from the Qwik.JS team and got a custom Vite plugin working with a Qwik app: https://github.com/nmn/qwik-stylex This plugin is able to handle generating and injecting CSS during development without runtime injection. With perhaps a few tweaks, this should enable a fairly universal Vite plugin. |
The interesting thing is that it works fine in my own repo :) |
This is an issue with ESM. Your plugin probably depends on StyleX publishing real ESM. We already have a PR for this, so we can see if rebasing after that PR fixes the issue. |
@nmn any updates on getting a stylex vite plugin in the main repo? I've been having issues with |
The PR is for implement a vite plugin. #47
Currently, @HorusGoul has already implemented it. But it can't cover many sences. like
css process by vite
, #44 and etc.CheckList
vite-example
.