Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove esm->cjs conversion from Webpack plugin #879

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Jan 30, 2025

What changed / motivation ?

Remove the Babel plugin that converts ESM to CJS from the Webpack plugin.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 30, 2025
Copy link

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

@stylexjs/scripts@0.10.1 size:compare
./size-compare.js /tmp/tmp.WNmHadtX1b /tmp/tmp.uKVtDXWhqT

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 1,013 1,013 1.00
· minified 3,305 3,305 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
rollup-example/.build/bundle.js
· compressed 567,110 567,110 1.00
· minified 10,232,512 10,232,512 1.00
rollup-example/.build/stylex.css
· compressed 100,628 100,628 1.00
· minified 755,718 755,718 1.00

@necolas necolas merged commit 478aa6b into main Feb 5, 2025
8 checks passed
@nmn nmn deleted the fix/webpack-no-commonjs branch February 6, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants