Use const qualified ssl context

Summary: Allow using const qualified ssl context. This avoids potential bugs due to sharing context among multiple connections. Reviewed By: hanidamlaj Differential Revision: D51874030 fbshipit-source-id: 61dfb1333085418ae729109be105e1991e42b4f2
facebook · Dec 7, 2023 · ec7de8a · ec7de8a
1 parent 2bcbfd2
commit ec7de8a
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/wangle/bootstrap/BaseClientBootstrap.h b/wangle/bootstrap/BaseClientBootstrap.h
@@ -88,7 +88,8 @@ class BaseClientBootstrap {
       const folly::SocketAddress& address,
       std::chrono::milliseconds timeout = std::chrono::milliseconds(0)) = 0;
 
-  BaseClientBootstrap* sslContext(folly::SSLContextPtr sslContext) {
+  BaseClientBootstrap* sslContext(
+      std::shared_ptr<const folly::SSLContext> sslContext) {
     sslContext_ = sslContext;
     return this;
   }
@@ -139,7 +140,7 @@ class BaseClientBootstrap {
 
   std::shared_ptr<PipelineFactory<P>> pipelineFactory_;
   typename P::Ptr pipeline_;
-  folly::SSLContextPtr sslContext_;
+  std::shared_ptr<const folly::SSLContext> sslContext_;
   std::shared_ptr<folly::ssl::SSLSession> sslSession_{nullptr};
   std::string sni_;
   bool deferSecurityNegotiation_{false};