Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watchman rust client panics on an unknown filetype in query results #911

Closed
cjhopman opened this issue May 19, 2021 · 1 comment
Closed

watchman rust client panics on an unknown filetype in query results #911

cjhopman opened this issue May 19, 2021 · 1 comment

Comments

@cjhopman
Copy link

Steps to reproduce:

get clock from a query with Expr::True as the expression
make changes that will cause watchman to have events with an unknown filetype (see #892 for ideas, or maybe simply edit a file in vscode)
do a since query with Expr::True as the expression

See:
panic with message containing "Watchman Server returned impossible file type ?', <...>/watchman_client-0.6.1/src/pdu.rs:674:24"
facebook-github-bot pushed a commit that referenced this issue Mar 12, 2022
@dgrnbrg-meta @facebook-github-bot
getdeps optionally can get hg info from env var (#911)
0a8d61f 
Summary:
X-link: rsocket/rsocket-cpp#911

X-link: facebookexperimental/rust-shed#32

X-link: facebookincubator/reindeer#3

X-link: https://github.com/fairinternal/AIRStore/pull/36

X-link: facebookincubator/velox#1197

X-link: facebook/mvfst#242

X-link: facebook/sapling#116

X-link: facebookincubator/fizz#75

X-link: facebookincubator/katran#157

Pull Request resolved: #1011

X-link: facebook/wangle#205

X-link: facebook/proxygen#401

X-link: facebook/openr#129

X-link: facebookarchive/fbzmq#35

X-link: facebook/fb303#26

X-link: facebookarchive/bistro#59

X-link: facebook/folly#1734

X-link: facebook/fboss#113

Adds an environment variable to getdeps to provide `hg` info to avoid calling `hg` directly.

When using `getdeps` inside a containerized environment (which we need to build Research Super Cluster tooling with the correct linker attributes), `getdeps` fails because of unregistered mercurial extensions in the `hgrc`.

This allows `getdeps` to be useable in an environment where the mercurial extensions used in a project aren't installed/available.

Reviewed By: vivekspai

Differential Revision: D34732506

fbshipit-source-id: 6475088fbf3323347095ca5af8a902382cf8f9d0
heartpunk pushed a commit to heartpunk/watchman that referenced this issue Mar 20, 2022
@dgrnbrg-meta @heartpunk
getdeps optionally can get hg info from env var (facebook#911)
1925394 
Summary:
X-link: rsocket/rsocket-cpp#911

X-link: facebookexperimental/rust-shed#32

X-link: facebookincubator/reindeer#3

X-link: https://github.com/fairinternal/AIRStore/pull/36

X-link: facebookincubator/velox#1197

X-link: facebook/mvfst#242

X-link: facebook/sapling#116

X-link: facebookincubator/fizz#75

X-link: facebookincubator/katran#157

Pull Request resolved: facebook#1011

X-link: facebook/wangle#205

X-link: facebook/proxygen#401

X-link: facebook/openr#129

X-link: facebookarchive/fbzmq#35

X-link: facebook/fb303#26

X-link: facebookarchive/bistro#59

X-link: facebook/folly#1734

X-link: facebook/fboss#113

Adds an environment variable to getdeps to provide `hg` info to avoid calling `hg` directly.

When using `getdeps` inside a containerized environment (which we need to build Research Super Cluster tooling with the correct linker attributes), `getdeps` fails because of unregistered mercurial extensions in the `hgrc`.

This allows `getdeps` to be useable in an environment where the mercurial extensions used in a project aren't installed/available.

Reviewed By: vivekspai

Differential Revision: D34732506

fbshipit-source-id: 6475088fbf3323347095ca5af8a902382cf8f9d0
@viveksjain
Copy link
Contributor

I hit this same issue, any update here?

@viveksjain viveksjain mentioned this issue May 28, 2022
Closed
facebook-github-bot pushed a commit that referenced this issue Jun 17, 2022
@viveksjain @facebook-github-bot
Fix handling unknown FileType in Rust client (#1029)
6cbffe3 
Summary:
Fixes #911

Pull Request resolved: #1029

Reviewed By: fanzeyi

Differential Revision: D37137717

Pulled By: genevievehelsel

fbshipit-source-id: a00cad4293d47c3b70a8573c4563362468cbb64a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix handling unknown FileType in Rust client viveksjain/watchman
2 participants
@cjhopman @viveksjain