Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation problems with modern versions of Folly #202

Closed
wants to merge 1 commit into from

Conversation

SashaNullptr
Copy link

Attempting to compile WDT against modern versions of Folly results in the following error when linking wdtbin (aliased to wdt).

libfolly4wdt.so: undefined reference to `folly::strlcpy(char*, char const*, unsigned long)'

It seems that the source files that define folly::strlcpy, namely lang/CString.cpp need to be included explicitly.

It also appears that this problem has already been addressed by a fork of WDT.

@facebook-github-bot
Copy link
Contributor

Hi SashaNullptr! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@SashaNullptr
Copy link
Author

Heh, just noticed the maintainer that I linked to already submitted a PR for this problem at #201

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@davide125
Copy link
Member

Duplicate of #201

@davide125 davide125 marked this as a duplicate of #201 Nov 12, 2020
@davide125 davide125 closed this Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants