Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-add unintentionally removed re-exported liballoc macros #263

Merged

Conversation

bitwalker
Copy link
Contributor

With the changes in #262, the re-exports of vec! and format! macros was unintentionally removed. This is required for backwards compatibility until the deprecated boxed, collections, and string modules are removed.

/cc @irakliyk

@bitwalker
Copy link
Contributor Author

@irakliyk I'm going to open up a PR against miden-crypto as well since a similar fix is needed there.

Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@irakliyk irakliyk merged commit fe9de89 into facebook:main Mar 18, 2024
9 checks passed
@irakliyk
Copy link
Collaborator

Patched version of winter-utils is now on crates.io.

@bitwalker bitwalker deleted the bitwalker/hotfix-liballoc-reexports branch March 18, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants