Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce degree of sum-check round polynomials #328

Merged

Conversation

Al-Kindi-0
Copy link
Contributor

Implements the optimization in Section 3.3 here.
Benchmarks show about 20% improvement in sum-check proving times.

Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I tried it with Miden VM and did observe an improvement. IMO we can do any cleanup later.

@Al-Kindi-0 Al-Kindi-0 force-pushed the al-logup-gkr-reduce-degree-new branch from 6f948c6 to 9b0bf25 Compare September 26, 2024 19:58
@Al-Kindi-0 Al-Kindi-0 force-pushed the al-logup-gkr-reduce-degree-new branch from bc9f8d4 to 4651b10 Compare September 27, 2024 16:55
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@irakliyk irakliyk merged commit d34e0b1 into facebook:logup-gkr Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants