Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CMake option to not build the tests #1624

Open
hedtke opened this issue Mar 14, 2024 · 2 comments
Open

Add a CMake option to not build the tests #1624

hedtke opened this issue Mar 14, 2024 · 2 comments

Comments

@hedtke
Copy link

hedtke commented Mar 14, 2024

I created a Conan package for yoga, but I have to patch out the line add_subdirectory(tests) in CMakeLists.txt because I do not want to build the tests when creating the package. A CMake option would be nice, something like option(BUILD_TESTS "Build tests" ON).

I am not allowed to contribute to yoga due to the Meta CLA, thus I closed the PR where I propose such a change.

@NickGerleman
Copy link
Contributor

What are build expectations of Conan? Yoga CMake structure is a bit messy, but if we don’t need bits which install Yoga headers to system, we could use https://github.com/facebook/yoga/blob/main/yoga/CMakeLists.txt directly.

@hedtke
Copy link
Author

hedtke commented Mar 15, 2024

At the moment building and packaging is done via

cmake --build --target yogacore
cmake --install

this we install the lib and the headers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants