Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added npm deploy when tags are pushed #113

Merged
merged 1 commit into from
Aug 18, 2015

Conversation

ColinEberhardt
Copy link
Contributor

With this configuration update a new package will automatically be deployed to npm when the repo is tagged. When this is merged I'd like to propose tagging and releasing v1.0.0

(css-layout is at 0.0.2, the recent changes were breaking, hence 1.0.0 under semver).

@chrisprice can you quickly double check my travis config? it all looks pretty straightforward, but wanted to check based on your prior experience!

closes #101

@chrisprice
Copy link

LGTM. I remember having problems with the format of the string I encrypted (which made it invalid) but you'll only find that out once you try it :)

@vjeux
Copy link
Contributor

vjeux commented Aug 18, 2015

So cool :)

ColinEberhardt added a commit that referenced this pull request Aug 18, 2015
Added npm deploy when tags are pushed
@ColinEberhardt ColinEberhardt merged commit ee6cf71 into facebook:master Aug 18, 2015
@ColinEberhardt
Copy link
Contributor Author

So cool :)

As long as it works! I'm going to try a 0.0.3 release from Travis, then if that works go for 1.0.0 :-)

@ColinEberhardt ColinEberhardt deleted the ci-releases branch August 18, 2015 18:39
@ColinEberhardt
Copy link
Contributor Author

as long as it works!

which it didn't :-(

The Travis build passed, but with the following:

Skipping a deployment with the npm provider because this is not a tagged commit

Although unless I am going crazy, this commit was tagged: 9c31f68

I've double-checked the travis config, but can't see any issues there - @chrisprice any ideas?

@chrisprice
Copy link

I think that's just a subtlety of how travis-ci works, it creates one build for the tag and one for the master branch commit. As you can see in the logs the first one attempted to deploy but the second one did not.

So why did it fail?

Deploying application
NPM API key format changed recently. If your deployment fails, check your API key in ~/.npmrc.
http://docs.travis-ci.com/user/deployment/npm/
-npm ERR! publish Failed PUT 401
npm ERR! Linux 3.13.0-40-generic
npm ERR! argv "/home/travis/.nvm/versions/node/v0.12.7/bin/node" "/home/travis/.nvm/versions/node/v0.12.7/bin/npm" "publish"
npm ERR! node v0.12.7
npm ERR! npm  v2.11.3
npm ERR! code E401
npm ERR! You must be logged in to publish packages : css-layout
npm ERR! 
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>
npm ERR! Please include the following file with any support request:
npm ERR!     /home/travis/build/facebook/css-layout/npm-debug.log

I'd guess that means the cleartext of the encrypted token is in the wrong format, I can help Colin debug it in person next time I see him (unless he wants to post his password here!).

@ColinEberhardt
Copy link
Contributor Author

Thanks Chris, I hadn't spotted that there were two separate builds. Hopefully we
can sort this out later this week.

On Wed, Aug 19, 2015 at 9:37 am, facebook/css-layout
reply@reply.github.com
wrote:
I think that's just a subtlety of how travis-ci works, it creates one build for the tag
[https://travis-ci.org/facebook/css-layout/builds/76158129] and one for the master branch commit
[https://travis-ci.org/facebook/css-layout/builds/76158137] . As you can see in the logs the first one attempted to deploy but the second
one did not.

So why did it fail?

Deploying application
NPM API key format changed recently. If your deployment fails, check your API key in ~/.npmrc.
http://docs.travis-ci.com/user/deployment/npm/
-npm ERR! publish Failed PUT 401
npm ERR! Linux 3.13.0-40-generic
npm ERR! argv "/home/travis/.nvm/versions/node/v0.12.7/bin/node" "/home/travis/.nvm/versions/node/v0.12.7/bin/npm" "publish"
npm ERR! node v0.12.7
npm ERR! npm v2.11.3
npm ERR! code E401
npm ERR! You must be logged in to publish packages : css-layout
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR! https://github.com/npm/npm/issues
npm ERR! Please include the following file with any support request:
npm ERR! /home/travis/build/facebook/css-layout/npm-debug.log

I'd guess that means the cleartext of the encrypted token is in the wrong
format, I can help Colin debug it in person next time I see him (unless he wants
to post his password here!).


Reply to this email directly or view it on GitHub
[https://github.com//pull/113#issuecomment-132493911] .[https://github.com/notifications/beacon/ABDBfltaf01XDXDtOrO7N9o3DZVjspdxks5opDfGgaJpZM4FtHAN.gif]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a release process
3 participants