-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added npm deploy when tags are pushed #113
Conversation
LGTM. I remember having problems with the format of the string I encrypted (which made it invalid) but you'll only find that out once you try it :) |
So cool :) |
Added npm deploy when tags are pushed
As long as it works! I'm going to try a 0.0.3 release from Travis, then if that works go for 1.0.0 :-) |
which it didn't :-( The Travis build passed, but with the following:
Although unless I am going crazy, this commit was tagged: 9c31f68 I've double-checked the travis config, but can't see any issues there - @chrisprice any ideas? |
I think that's just a subtlety of how travis-ci works, it creates one build for the tag and one for the So why did it fail?
I'd guess that means the cleartext of the encrypted token is in the wrong format, I can help Colin debug it in person next time I see him (unless he wants to post his password here!). |
Thanks Chris, I hadn't spotted that there were two separate builds. Hopefully we On Wed, Aug 19, 2015 at 9:37 am, facebook/css-layout So why did it fail? Deploying application I'd guess that means the cleartext of the encrypted token is in the wrong — |
With this configuration update a new package will automatically be deployed to npm when the repo is tagged. When this is merged I'd like to propose tagging and releasing v1.0.0
(css-layout is at 0.0.2, the recent changes were breaking, hence 1.0.0 under semver).
@chrisprice can you quickly double check my travis config? it all looks pretty straightforward, but wanted to check based on your prior experience!
closes #101