Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added suppression for warnings about unused parameters in 'publish<Type E>()' func #1141

Closed
wants to merge 2 commits into from
Closed

Added suppression for warnings about unused parameters in 'publish<Type E>()' func #1141

wants to merge 2 commits into from

Conversation

inobelar
Copy link
Contributor

No description provided.

@facebook-github-bot
Copy link
Contributor

Hi @inobelar!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

NickGerleman
NickGerleman approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@NickGerleman NickGerleman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As a nit [[maybe_unused]] might be a clearer way to do the same thing.

Edit: [[maybe_unused]] is part of C++ 17 and Yoga targets C++ 11 right now, so this wouldn't work yet.

@facebook-github-bot
Copy link
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Oct 4, 2022
@inobelar @facebook-github-bot
Added suppression for warnings about unused parameters in 'publish<Ty…
ec0a829 
…pe E>()' func (#1141)

Summary: Pull Request resolved: #1141

Reviewed By: yungsters

Differential Revision: D40025354

Pulled By: yungsters

fbshipit-source-id: 6eaaa77b71db95ab0dbc0a4f459c9d85f7e36c42
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Oct 4, 2022
@inobelar @facebook-github-bot
Added suppression for warnings about unused parameters in 'publish<Ty…
c136398 
…pe E>()' func (#1141)

Summary: Pull Request resolved: facebook/yoga#1141

Reviewed By: yungsters

Differential Revision: D40025354

Pulled By: yungsters

fbshipit-source-id: 6eaaa77b71db95ab0dbc0a4f459c9d85f7e36c42
@inobelar inobelar deleted the patch-1 branch October 4, 2022 10:39
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@inobelar @OlimpiaZurek
Added suppression for warnings about unused parameters in 'publish<Ty…
edf5058 
…pe E>()' func (facebook#1141)

Summary: Pull Request resolved: facebook/yoga#1141

Reviewed By: yungsters

Differential Revision: D40025354

Pulled By: yungsters

fbshipit-source-id: 6eaaa77b71db95ab0dbc0a4f459c9d85f7e36c42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickGerleman NickGerleman NickGerleman approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inobelar @facebook-github-bot @NickGerleman