<bit> and <concepts> #1497
Closed
<bit> and <concepts> #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D51604487 |
NickGerleman
force-pushed
the
export-D51604487
branch
from
08bc5d0 to
850573e
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Dec 7, 2023
Summary: X-link: facebook/react-native#41822 The lowest common denominator build encountered for Yoga internally has been Clang 12 + MSVC 2017 stdlib. This has allowed Yoga to use C++ 20 language features, but not library features. React Native for mobile has not been bound to this restriction. Builds using that toolchain are being updated to latest MSVC 2019 stdlib (which has good C++ 20 library support), along with Clang 17 (or maybe a stop at 15) pending projects using `-fcoroutines-ts` being migrated to C++ 20. This tests out some C++ 20 standard library usages against the current Clang 12 + MSVC 2019 stdlib toolchain, and adds a couple concepts for better constraints/compiler error messages if misused. Yoga OSS CI tests as far back as Clang/libc++ 14 along with a similar era GCC/libstdc++ as part of tests against Ubuntu 22.04 LTS stock toolchain. Once this internal toolchain is updated, that will be the least common denominator (compared to mobile builds or any internal builds). Changelog: [Internal] Differential Revision: D51604487
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Dec 7, 2023
Summary: X-link: facebook/yoga#1497 The lowest common denominator build encountered for Yoga internally has been Clang 12 + MSVC 2017 stdlib. This has allowed Yoga to use C++ 20 language features, but not library features. React Native for mobile has not been bound to this restriction. Builds using that toolchain are being updated to latest MSVC 2019 stdlib (which has good C++ 20 library support), along with Clang 17 (or maybe a stop at 15) pending projects using `-fcoroutines-ts` being migrated to C++ 20. This tests out some C++ 20 standard library usages against the current Clang 12 + MSVC 2019 stdlib toolchain, and adds a couple concepts for better constraints/compiler error messages if misused. Yoga OSS CI tests as far back as Clang/libc++ 14 along with a similar era GCC/libstdc++ as part of tests against Ubuntu 22.04 LTS stock toolchain. Once this internal toolchain is updated, that will be the least common denominator (compared to mobile builds or any internal builds). Changelog: [Internal] Differential Revision: D51604487
|
This pull request was exported from Phabricator. Differential Revision: D51604487 |
NickGerleman
force-pushed
the
export-D51604487
branch
from
850573e to
9c2c7fc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51604487 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Dec 7, 2023
Summary: The lowest common denominator build encountered for Yoga internally has been Clang 12 + MSVC 2017 stdlib. This has allowed Yoga to use C++ 20 language features, but not library features. React Native for mobile has not been bound to this restriction. Builds using that toolchain are being updated to latest MSVC 2019 stdlib (which has good C++ 20 library support), along with Clang 17 (or maybe a stop at 15) pending projects using `-fcoroutines-ts` being migrated to C++ 20. This tests out some C++ 20 standard library usages against the current Clang 12 + MSVC 2019 stdlib toolchain that didn't work before, and adds a couple concepts for better constraints/compiler error messages if misused. Yoga OSS CI tests as far back as Clang/libc++ 14 along with a similar era GCC/libstdc++ as part of tests against Ubuntu 22.04 LTS stock toolchain. Once this internal toolchain is updated, that will be the least common denominator (compared to mobile builds or any internal builds). Changelog: [Internal] Differential Revision: D51604487
NickGerleman
force-pushed
the
export-D51604487
branch
from
9c2c7fc to
699d063
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51604487 |
NickGerleman
force-pushed
the
export-D51604487
branch
from
699d063 to
7a95b19
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Dec 7, 2023
Summary: The lowest common denominator build encountered for Yoga internally has been Clang 12 + MSVC 2017 stdlib. This has allowed Yoga to use C++ 20 language features, but not library features. React Native for mobile has not been bound to this restriction. Builds using that toolchain are being updated to latest MSVC 2019 stdlib (which has good C++ 20 library support), along with Clang 17 (or maybe a stop at 15) pending projects using `-fcoroutines-ts` being migrated to C++ 20. This tests out some C++ 20 standard library usages against the current Clang 12 + MSVC 2019 stdlib toolchain that didn't work before, and adds a couple concepts for better constraints/compiler error messages if misused. Yoga OSS CI tests as far back as Clang/libc++ 14 along with a similar era GCC/libstdc++ as part of tests against Ubuntu 22.04 LTS stock toolchain. Once this internal toolchain is updated, that will be the least common denominator (compared to mobile builds or any internal builds). Changelog: [Internal] Differential Revision: D51604487
|
This pull request was exported from Phabricator. Differential Revision: D51604487 |
NickGerleman
force-pushed
the
export-D51604487
branch
from
7a95b19 to
a6259d9
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Dec 7, 2023
Summary: The lowest common denominator we have had for Yoga has been Clang 12 + MSVC 2017 stdlib. This has allowed Yoga to use C++ 20 language features, but not library features. React Native for mobile has not been bound to this restriction. Builds using that toolchain are being updated to latest MSVC 2019 stdlib (which has good C++ 20 library support), along with Clang 17 (or maybe a stop at 15) pending projects using `-fcoroutines-ts` being migrated to C++ 20. This tests out some C++ 20 standard library usages against the current Clang 12 + MSVC 2019 stdlib toolchain that didn't work before, and adds a couple concepts for better constraints/compiler error messages if misused. This bumps min-tested XCode (and minimum required) version to 14.3, matching a similar change for React Native. This should probably be bumped to 15 sometime before Apple starts requiring 15+ to go out to the iOS app store. We are approaching a practical support range of: 1. XCode >= 14.3 2. NDK >= 26 3. Clang/libc++ >= 14 4. GCC/libstdc++ >= 11 5. MSVC >= 16.11 (VS 2019) Changelog: [Internal] Differential Revision: D51604487
|
This pull request was exported from Phabricator. Differential Revision: D51604487 |
NickGerleman
force-pushed
the
export-D51604487
branch
from
a6259d9 to
212474b
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Dec 9, 2023
Summary: The lowest common denominator we have had for Yoga has been Clang 12 + MSVC 2017 stdlib. This has allowed Yoga to use C++ 20 language features, but not library features. React Native for mobile has not been bound to this restriction. Builds using that toolchain are being updated to latest MSVC 2019 stdlib (which has good C++ 20 library support), along with Clang 17 (or maybe a stop at 15) pending projects using `-fcoroutines-ts` being migrated to C++ 20. This tests out some C++ 20 standard library usages against the current Clang 12 + MSVC 2019 stdlib toolchain that didn't work before, and adds a couple concepts for better constraints/compiler error messages if misused. This bumps min-tested XCode (and minimum required) version to 14.3, matching a similar change for React Native. This should probably be bumped to 15 sometime before Apple starts requiring 15+ to go out to the iOS app store. We are approaching a practical support range of: 1. XCode >= 14.3 2. NDK >= 26 3. Clang/libc++ >= 14 4. GCC/libstdc++ >= 11 5. MSVC >= 16.11 (VS 2019) Changelog: [Internal] Differential Revision: D51604487
|
This pull request was exported from Phabricator. Differential Revision: D51604487 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D51604487 |
NickGerleman
force-pushed
the
export-D51604487
branch
from
212474b to
358c167
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Dec 12, 2023
Summary: The lowest common denominator we have had for Yoga has been Clang 12 + MSVC 2017 stdlib. This has allowed Yoga to use C++ 20 language features, but not library features. React Native for mobile has not been bound to this restriction. Builds using that toolchain are being updated to latest MSVC 2019 stdlib (which has good C++ 20 library support), along with Clang 17 (or maybe a stop at 15) pending projects using `-fcoroutines-ts` being migrated to C++ 20. This tests out some C++ 20 standard library usages against the current Clang 12 + MSVC 2019 stdlib toolchain that didn't work before, and adds a couple concepts for better constraints/compiler error messages if misused. This bumps min-tested XCode (and minimum required) version to 14.3, matching a similar change for React Native. This should probably be bumped to 15 sometime before Apple starts requiring 15+ to go out to the iOS app store. We are approaching a practical support range of: 1. XCode >= 14.3 2. NDK >= 26 3. Clang/libc++ >= 14 4. GCC/libstdc++ >= 11 5. MSVC >= 16.11 (VS 2019) Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51604487
|
This pull request was exported from Phabricator. Differential Revision: D51604487 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Dec 12, 2023
Summary: The lowest common denominator we have had for Yoga has been Clang 12 + MSVC 2017 stdlib. This has allowed Yoga to use C++ 20 language features, but not library features. React Native for mobile has not been bound to this restriction. Builds using that toolchain are being updated to latest MSVC 2019 stdlib (which has good C++ 20 library support), along with Clang 17 (or maybe a stop at 15) pending projects using `-fcoroutines-ts` being migrated to C++ 20. This tests out some C++ 20 standard library usages against the current Clang 12 + MSVC 2019 stdlib toolchain that didn't work before, and adds a couple concepts for better constraints/compiler error messages if misused. This bumps min-tested XCode (and minimum required) version to 14.3, matching a similar change for React Native. This should probably be bumped to 15 sometime before Apple starts requiring 15+ to go out to the iOS app store. We are approaching a practical support range of: 1. XCode >= 14.3 2. NDK >= 26 3. Clang/libc++ >= 14 4. GCC/libstdc++ >= 11 5. MSVC >= 16.11 (VS 2019) Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51604487
NickGerleman
force-pushed
the
export-D51604487
branch
from
358c167 to
b30d1bc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51604487 |
Summary: The lowest common denominator we have had for Yoga has been Clang 12 + MSVC 2017 stdlib. This has allowed Yoga to use C++ 20 language features, but not library features. React Native for mobile has not been bound to this restriction. Builds using that toolchain are being updated to latest MSVC 2019 stdlib (which has good C++ 20 library support), along with Clang 17 (or maybe a stop at 15) pending projects using `-fcoroutines-ts` being migrated to C++ 20. This tests out some C++ 20 standard library usages against the current Clang 12 + MSVC 2019 stdlib toolchain that didn't work before, and adds a couple concepts for better constraints/compiler error messages if misused. This bumps min-tested XCode (and minimum required) version to 14.3, matching a similar change for React Native. This should probably be bumped to 15 sometime before Apple starts requiring 15+ to go out to the iOS app store. We are approaching a practical support range of: 1. XCode >= 14.3 2. NDK >= 26 3. Clang/libc++ >= 14 4. GCC/libstdc++ >= 11 5. MSVC >= 16.11 (VS 2019) Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51604487
NickGerleman
force-pushed
the
export-D51604487
branch
from
b30d1bc to
3ba9d1a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51604487 |
|
This pull request has been merged in a437542. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Dec 12, 2023
Summary: X-link: facebook/yoga#1497 The lowest common denominator we have had for Yoga has been Clang 12 + MSVC 2017 stdlib. This has allowed Yoga to use C++ 20 language features, but not library features. React Native for mobile has not been bound to this restriction. Builds using that toolchain are being updated to latest MSVC 2019 stdlib (which has good C++ 20 library support), along with Clang 17 (or maybe a stop at 15) pending projects using `-fcoroutines-ts` being migrated to C++ 20. This tests out some C++ 20 standard library usages against the current Clang 12 + MSVC 2019 stdlib toolchain that didn't work before, and adds a couple concepts for better constraints/compiler error messages if misused. This bumps min-tested XCode (and minimum required) version to 14.3, matching a similar change for React Native. This should probably be bumped to 15 sometime before Apple starts requiring 15+ to go out to the iOS app store. We are approaching a practical support range of: 1. XCode >= 14.3 2. NDK >= 26 3. Clang/libc++ >= 14 4. GCC/libstdc++ >= 11 5. MSVC >= 16.11 (VS 2019) Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51604487 fbshipit-source-id: d394d0d86672b69781b8ae071d87adcf944ddc72
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Dec 12, 2023
Summary: X-link: facebook/yoga#1497 The lowest common denominator we have had for Yoga has been Clang 12 + MSVC 2017 stdlib. This has allowed Yoga to use C++ 20 language features, but not library features. React Native for mobile has not been bound to this restriction. Builds using that toolchain are being updated to latest MSVC 2019 stdlib (which has good C++ 20 library support), along with Clang 17 (or maybe a stop at 15) pending projects using `-fcoroutines-ts` being migrated to C++ 20. This tests out some C++ 20 standard library usages against the current Clang 12 + MSVC 2019 stdlib toolchain that didn't work before, and adds a couple concepts for better constraints/compiler error messages if misused. This bumps min-tested XCode (and minimum required) version to 14.3, matching a similar change for React Native. This should probably be bumped to 15 sometime before Apple starts requiring 15+ to go out to the iOS app store. We are approaching a practical support range of: 1. XCode >= 14.3 2. NDK >= 26 3. Clang/libc++ >= 14 4. GCC/libstdc++ >= 11 5. MSVC >= 16.11 (VS 2019) Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51604487 fbshipit-source-id: d394d0d86672b69781b8ae071d87adcf944ddc72
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: X-link: facebook/yoga#1497 The lowest common denominator we have had for Yoga has been Clang 12 + MSVC 2017 stdlib. This has allowed Yoga to use C++ 20 language features, but not library features. React Native for mobile has not been bound to this restriction. Builds using that toolchain are being updated to latest MSVC 2019 stdlib (which has good C++ 20 library support), along with Clang 17 (or maybe a stop at 15) pending projects using `-fcoroutines-ts` being migrated to C++ 20. This tests out some C++ 20 standard library usages against the current Clang 12 + MSVC 2019 stdlib toolchain that didn't work before, and adds a couple concepts for better constraints/compiler error messages if misused. This bumps min-tested XCode (and minimum required) version to 14.3, matching a similar change for React Native. This should probably be bumped to 15 sometime before Apple starts requiring 15+ to go out to the iOS app store. We are approaching a practical support range of: 1. XCode >= 14.3 2. NDK >= 26 3. Clang/libc++ >= 14 4. GCC/libstdc++ >= 11 5. MSVC >= 16.11 (VS 2019) Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51604487 fbshipit-source-id: d394d0d86672b69781b8ae071d87adcf944ddc72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The lowest common denominator build encountered for Yoga internally has been Clang 12 + MSVC 2017 stdlib. This has allowed Yoga to use C++ 20 language features, but not library features. React Native for mobile has not been bound to this restriction.
Builds using that toolchain are being updated to latest MSVC 2019 stdlib (which has good C++ 20 library support), along with Clang 17 (or maybe a stop at 15) pending projects using
-fcoroutines-tsbeing migrated to C++ 20.This tests out some C++ 20 standard library usages against the current Clang 12 + MSVC 2019 stdlib toolchain, and adds a couple concepts for better constraints/compiler error messages if misused.
Yoga OSS CI tests as far back as Clang/libc++ 14 along with a similar era GCC/libstdc++ as part of tests against Ubuntu 22.04 LTS stock toolchain. Once this internal toolchain is updated, that will be the least common denominator (compared to mobile builds or any internal builds).
Changelog: [Internal]
Differential Revision: D51604487