Use quote style for local includes #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
Summary: This PR changes `#include <CSSLayout/*.h>` to `#include "*.h"` within the `CSSLayout` directory. Rationale: Quote includes are preferred for user (aka local/project) includes, whereas angle includes are preferred for standard libraries and external frameworks. In particular, XCode 7.1+ will not search user paths (even the current directory) when angle brackets are used unless "Always search user paths" is enabled - it is off by default and [Apple recommend](https://developer.apple.com/library/mac/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW110) that it is only enabled for backwards compatibility. I think this is the best fix for facebook/react-native#9014, and seems like good practice in any case. Closes #217 Reviewed By: majak Differential Revision: D3764132 Pulled By: emilsjolander fbshipit-source-id: c8a6e8d19db71455922e3ba8f6c72bd66018fa84
ghost
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 6, 2016
Summary: Include CSSLayout headers in the same way as other project headers, ie `#import <CSSLayout/CSSLayout.h>` becomes `#import "CSSLayout.h"`. CSSLayout is not a framework or system dependency, so shouldn't (AFAIK) be included with angle brackets. Doing so breaks framework builds, such as when RN is used as a pod in a swift project. In combination with facebook/yoga#217 this fixes #9014 (specifically swift cocoapods projects). There is then no need for a separate CSSLayout pod subspec. Tests run on the RN project in isolation (with changes inside `CSSLayout` itself also applied) and against a dummy swift project with RN included as a pod. NB: This effectively reverts #9015 and may break non-swift cocoapods projects unless facebook/yoga#217 is merged and synced first. Update: As discussed with alloy and emilsjolander, wrap these imports in a preprocess Closes #9544 Differential Revision: D3821791 Pulled By: javache fbshipit-source-id: d27ac8be9ce560d03479b43d3db740cd196c24da
mikelambert
pushed a commit
to mikelambert/react-native
that referenced
this pull request
Sep 19, 2016
Summary: Include CSSLayout headers in the same way as other project headers, ie `#import <CSSLayout/CSSLayout.h>` becomes `#import "CSSLayout.h"`. CSSLayout is not a framework or system dependency, so shouldn't (AFAIK) be included with angle brackets. Doing so breaks framework builds, such as when RN is used as a pod in a swift project. In combination with facebook/yoga#217 this fixes facebook#9014 (specifically swift cocoapods projects). There is then no need for a separate CSSLayout pod subspec. Tests run on the RN project in isolation (with changes inside `CSSLayout` itself also applied) and against a dummy swift project with RN included as a pod. NB: This effectively reverts facebook#9015 and may break non-swift cocoapods projects unless facebook/yoga#217 is merged and synced first. Update: As discussed with alloy and emilsjolander, wrap these imports in a preprocess Closes facebook#9544 Differential Revision: D3821791 Pulled By: javache fbshipit-source-id: d27ac8be9ce560d03479b43d3db740cd196c24da
spikebrehm
pushed a commit
to airbnb/react-native
that referenced
this pull request
Sep 20, 2016
Summary: Include CSSLayout headers in the same way as other project headers, ie `#import <CSSLayout/CSSLayout.h>` becomes `#import "CSSLayout.h"`. CSSLayout is not a framework or system dependency, so shouldn't (AFAIK) be included with angle brackets. Doing so breaks framework builds, such as when RN is used as a pod in a swift project. In combination with facebook/yoga#217 this fixes facebook#9014 (specifically swift cocoapods projects). There is then no need for a separate CSSLayout pod subspec. Tests run on the RN project in isolation (with changes inside `CSSLayout` itself also applied) and against a dummy swift project with RN included as a pod. NB: This effectively reverts facebook#9015 and may break non-swift cocoapods projects unless facebook/yoga#217 is merged and synced first. Update: As discussed with alloy and emilsjolander, wrap these imports in a preprocess Closes facebook#9544 Differential Revision: D3821791 Pulled By: javache fbshipit-source-id: d27ac8be9ce560d03479b43d3db740cd196c24da
spikebrehm
pushed a commit
to airbnb/react-native
that referenced
this pull request
Sep 21, 2016
Summary: This PR changes `#include <CSSLayout/*.h>` to `#include "*.h"` within the `CSSLayout` directory. Rationale: Quote includes are preferred for user (aka local/project) includes, whereas angle includes are preferred for standard libraries and external frameworks. In particular, XCode 7.1+ will not search user paths (even the current directory) when angle brackets are used unless "Always search user paths" is enabled - it is off by default and [Apple recommend](https://developer.apple.com/library/mac/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW110) that it is only enabled for backwards compatibility. I think this is the best fix for facebook#9014, and seems like good practice in any case. Closes facebook/yoga#217 Reviewed By: majak Differential Revision: D3764132 Pulled By: emilsjolander fbshipit-source-id: c8a6e8d19db71455922e3ba8f6c72bd66018fa84
spikebrehm
pushed a commit
to airbnb/react-native
that referenced
this pull request
Sep 21, 2016
Summary: Include CSSLayout headers in the same way as other project headers, ie `#import <CSSLayout/CSSLayout.h>` becomes `#import "CSSLayout.h"`. CSSLayout is not a framework or system dependency, so shouldn't (AFAIK) be included with angle brackets. Doing so breaks framework builds, such as when RN is used as a pod in a swift project. In combination with facebook/yoga#217 this fixes facebook#9014 (specifically swift cocoapods projects). There is then no need for a separate CSSLayout pod subspec. Tests run on the RN project in isolation (with changes inside `CSSLayout` itself also applied) and against a dummy swift project with RN included as a pod. NB: This effectively reverts facebook#9015 and may break non-swift cocoapods projects unless facebook/yoga#217 is merged and synced first. Update: As discussed with alloy and emilsjolander, wrap these imports in a preprocess Closes facebook#9544 Differential Revision: D3821791 Pulled By: javache fbshipit-source-id: d27ac8be9ce560d03479b43d3db740cd196c24da
gilbox
pushed a commit
to gilbox/react-native
that referenced
this pull request
Nov 23, 2016
Summary: This PR changes `#include <CSSLayout/*.h>` to `#include "*.h"` within the `CSSLayout` directory. Rationale: Quote includes are preferred for user (aka local/project) includes, whereas angle includes are preferred for standard libraries and external frameworks. In particular, XCode 7.1+ will not search user paths (even the current directory) when angle brackets are used unless "Always search user paths" is enabled - it is off by default and [Apple recommend](https://developer.apple.com/library/mac/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW110) that it is only enabled for backwards compatibility. I think this is the best fix for facebook#9014, and seems like good practice in any case. Closes facebook/yoga#217 Reviewed By: majak Differential Revision: D3764132 Pulled By: emilsjolander fbshipit-source-id: c8a6e8d19db71455922e3ba8f6c72bd66018fa84
gilbox
pushed a commit
to airbnb/react-native
that referenced
this pull request
Nov 23, 2016
Summary: This PR changes `#include <CSSLayout/*.h>` to `#include "*.h"` within the `CSSLayout` directory. Rationale: Quote includes are preferred for user (aka local/project) includes, whereas angle includes are preferred for standard libraries and external frameworks. In particular, XCode 7.1+ will not search user paths (even the current directory) when angle brackets are used unless "Always search user paths" is enabled - it is off by default and [Apple recommend](https://developer.apple.com/library/mac/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW110) that it is only enabled for backwards compatibility. I think this is the best fix for facebook#9014, and seems like good practice in any case. Closes facebook/yoga#217 Reviewed By: majak Differential Revision: D3764132 Pulled By: emilsjolander fbshipit-source-id: c8a6e8d19db71455922e3ba8f6c72bd66018fa84
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
#include <CSSLayout/*.h>to#include "*.h"within theCSSLayoutdirectory.Rationale: Quote includes are preferred for user (aka local/project) includes, whereas angle includes are preferred for standard libraries and external frameworks. In particular, XCode 7.1+ will not search user paths (even the current directory) when angle brackets are used unless "Always search user paths" is enabled - it is off by default and Apple recommend that it is only enabled for backwards compatibility.
I think this is the best fix for facebook/react-native#9014, and seems like good practice in any case.