Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ifndef guards for _LARGEFILE_SOURCE and _LARGEFILE64_SOURCE #2444

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Add ifndef guards for _LARGEFILE_SOURCE and _LARGEFILE64_SOURCE #2444

merged 1 commit into from
Dec 28, 2020

Commits on Dec 26, 2020

  1. Add ifndef guards for _LARGEFILE_SOURCE and _LARGEFILE64_SOURCE 

    This ensures the symbols aren't redefined, which would result in a compiler
error.

I was getting redefined symbols for _LARGEFILE64_SOURCE when building for
32-bit x86 Linux on an older CentOS release in a CI environment. With this
change, I'm able to compile the single file library in this environment.

Closes facebook#2443.
    @indygreg
    indygreg committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    dd1a7e4 View commit details
    Browse the repository at this point in the history