Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect .. in Paths Correctly #2512

Merged
merged 2 commits into from
Feb 26, 2021
Merged

Detect .. in Paths Correctly #2512

merged 2 commits into from
Feb 26, 2021

Conversation

felixhandte
Copy link
Contributor

This commit addresses #2509.

As it's a static function, I don't know a good way to test it directly. I tested it some via --output-dir-mirror on the CLI, all of which seemed to work well.

@Cyan4973
Copy link
Contributor

I don't know a good way to test it directly. I tested it some via --output-dir-mirror on the CLI, all of which seemed to work well.

Adding a test case employing --output-dir-mirror looks good enough to me.

@felixhandte felixhandte merged commit 45ee23f into facebook:dev Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants