Add AIX support in Makefile #2747
Conversation
For lib, AIX linker doesn't allow --soname.
|
Hi @Helflym! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
| @@ -212,7 +212,11 @@ ifeq ($(UNAME), Darwin) | |||
| SHARED_EXT_VER = $(LIBVER).$(SHARED_EXT) | |||
| SONAME_FLAGS = -install_name $(LIBDIR)/libzstd.$(SHARED_EXT_MAJOR) -compatibility_version $(LIBVER_MAJOR) -current_version $(LIBVER) | |||
| else | |||
| SONAME_FLAGS = -Wl,-soname=libzstd.$(SHARED_EXT).$(LIBVER_MAJOR) | |||
| ifeq ($(UNAME), AIX) | |||
| SONAME_FLAGS = | |||
There was a problem hiding this comment.
That part feels weird.
What happens to dynamic libraries in the context of AIX ?
There was a problem hiding this comment.
AIX linker doesn't simply understand -soname flag. GCC when calling the linker will pass the right arguments as long as "-shared" is provided. The "-o" flag is enough to have the correct soname.
|
Thanks for this proposed PR. Note though that the |
| @@ -374,7 +378,7 @@ clean: | |||
| #----------------------------------------------------------------------------- | |||
| # make install is validated only for below listed environments | |||
| #----------------------------------------------------------------------------- | |||
| ifneq (,$(filter $(UNAME),Linux Darwin GNU/kFreeBSD GNU OpenBSD FreeBSD NetBSD DragonFly SunOS Haiku)) | |||
| ifneq (,$(filter $(UNAME),Linux Darwin GNU/kFreeBSD GNU OpenBSD FreeBSD NetBSD DragonFly SunOS Haiku AIX)) | |||
There was a problem hiding this comment.
tangentially related :
It seems we have the same list of uname identifiers in 3 different places (for the purpose of controlling make install compatibility).
We could probably consolidate this list in one place and distribute it, making its maintenance and evolution a bit easier.
cc @felixhandte .
Just to give an update, I'm still waiting for the CLA to be signed by my company. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This PR adds two patches for AIX.
One for adding the general support of AIX inside Makefile.
One to remove the test dealing with /dev/full for AIX.