Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[asm] Share portability macros and restrict ASM further #2893

Merged
merged 1 commit into from
Dec 3, 2021
Merged

[asm] Share portability macros and restrict ASM further #2893

merged 1 commit into from
Dec 3, 2021

Commits on Dec 3, 2021

  1. [asm] Share portability macros and restrict ASM further 

    Move portability macros to `lib/common/portability_macros.h`. This file
only contains platform/feature detection (e.g. 0/1 macros). This file is
shared between C and ASM code, so it cannot include any C code.

Rename `HUF_` ASM macros to be `ZSTD_` prefixed, and move to the new
header.

Restrict `ZSTD_ASM_SUPPORTED` to `__GNUC__`, because we need the GAS
assembler.

Finally, only include the ASM code if we are actually going to use it.
This disables it on all Windows platforms, which should resolve the
problem brought up in Issue facebook#2789.
    @terrelln
    terrelln committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    c284569 View commit details
    Browse the repository at this point in the history