Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate parameter adaption from display update rate #3354

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Separate parameter adaption from display update rate #3354

merged 1 commit into from
Dec 15, 2022

Commits on Dec 15, 2022

  1. [fileio] Separate parameter adaption from display update rate 

    Split the logic for parameter adaption from the logic to update the display rate.
This decouples the two updates, so changes to display updates don't affect
parameter adaption.

Also add a test case that checks that parameter adaption actually happens.

This fixes Issue facebook#3353, where --adapt is broken when --no-progress is passed.
    @terrelln
    terrelln committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    801f964 View commit details
    Browse the repository at this point in the history