Introduce salt into row hash (#3528 part 2) #3533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds memory type that is guaranteed to have been initialized at least once in the workspace's lifetime. - Changes tag space in row hash to be based on init once memory. - Moves buffers to aligned memory and removes the buffer memory type.
…o allocate them after aligned buffers
yoniko
force-pushed
the
tag-space-hash-salting-3528-part2
branch
from
0273206 to
e18c951
Compare
yoniko
force-pushed
the
tag-space-hash-salting-3528-part2
branch
from
a8f72d2 to
029b84f
Compare
|
PR performance seems to be on PR with previous versions' performance for the samples I've tested. |
|
@Cyan4973 - I've added some more entropy to the salt, let me know what you think |
This helps to avoid regressions where consecutive compressions use the same tag space with similar data (running `zstd -b5e7 enwik8 -B128K` reproduces this regression).
yoniko
force-pushed
the
tag-space-hash-salting-3528-part2
branch
from
d4dff59 to
93dcd83
Compare
yoniko
force-pushed
the
tag-space-hash-salting-3528-part2
branch
from
93dcd83 to
2543295
Compare
- Adds memory type that is guaranteed to have been initialized at least once in the workspace's lifetime. - Changes tag space in row hash to be based on init once memory. - Moves buffers to aligned memory and removes the buffer memory type.
…o allocate them after aligned buffers
yoniko
force-pushed
the
tag-space-hash-salting-3528-part2
branch
from
8f2280c to
a8c62ff
Compare
|
@Cyan4973 - is there any other change you'll like to see here? |
Cyan4973
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of #3528
Adds hash salt that helps to avoid regressions where consecutive compressions use the same tag space with similar data (running
zstd -b5e7 enwik8 -B128Kreproduces this regression).Note: based on #3528 and includes it, see only diffs introduced here by selecting only the changes from last commit, or by viewing yoniko#13