This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
[ASVideoNode] Several small bug fixes, improved code quality, added more tests. #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| static UIViewContentMode ASContentModeFromVideoGravity(NSString *videoGravity) { | ||
| if ([videoGravity isEqualToString:AVLayerVideoGravityResizeAspect]) { | ||
| return UIViewContentModeScaleAspectFit; | ||
| } else if ([videoGravity isEqual:AVLayerVideoGravityResizeAspectFill]) { |
appleguy
changed the title
|
@ejensen thanks again! Feel free to wait a few days until the other changes affecting this file have merged, to minimize the risk of conflicts, But I am looking forward to the other diff. |
|
@appleguy Thanks for the review! I've incorporated your suggestions in the second PR of the bunch. I tried to minimize conflicts as much as possible. Feel free to hold off the second PR until you see fit. I know thrashing on a file is painful. If any conflict arise, I can rebase, wash, and repeat. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isolated fixes extracted from #1496 These changes do not touch the player construction / fetchData cleanup from the original PR. I will rebase those changes in a separate PR.
AVLayerVideoGravityResizeand its correspondingUIViewContentMode(ScaleToFillinstead ofRedraw).contentMode.playButtonnow cleans-up the previous button's state.