Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

Automatically log push opened event on card view appear. #10

Merged
merged 1 commit into from
Apr 25, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion iOS/FBNotifications/FBNotifications/FBNCardViewController.m
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

@interface FBNCardViewController () <FBNCardActionsViewDelegate>

@property (nonatomic, copy, readonly) NSString *campaignIdentifier;
@property (nullable, nonatomic, copy, readonly) NSString *campaignIdentifier;
@property (nonatomic, strong, readonly) FBNAssetsController *assetsController;

@property (nonatomic, strong) FBNCardConfiguration *configuration;
Expand Down Expand Up @@ -76,6 +76,24 @@ - (instancetype)initWithPushCardPayload:(FBNCardPayload *)payload

- (void)dealloc {
[self.dismissButton removeTarget:nil action:nil forControlEvents:UIControlEventAllEvents];
[[NSNotificationCenter defaultCenter] removeObserver:self];
}

///--------------------------------------
#pragma mark - View
///--------------------------------------

- (void)viewDidAppear:(BOOL)animated {
[super viewDidAppear:animated];

if ([UIApplication sharedApplication].applicationState != UIApplicationStateBackground) {
[self _logPushOpen];
} else {
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(_applicationWillEnterForeground)
name:UIApplicationWillEnterForegroundNotification
object:nil];
}
}

///--------------------------------------
Expand Down Expand Up @@ -246,6 +264,23 @@ - (void)viewWillLayoutSubviews {
self.loadingIndicatorView.center = CGPointMake(CGRectGetMidX(bounds), CGRectGetMidY(bounds));
}

///--------------------------------------
#pragma mark - Application State Changes
///--------------------------------------

- (void)_applicationWillEnterForeground {
[self _logPushOpen];
[[NSNotificationCenter defaultCenter] removeObserver:self name:UIApplicationWillEnterForegroundNotification object:nil];
}

///--------------------------------------
#pragma mark - Logging Events
///--------------------------------------

- (void)_logPushOpen {
[FBNCardAppEventsLogger logCardOpenWithCampaignIdentifier:self.campaignIdentifier];
}

///--------------------------------------
#pragma mark - Dismiss
///--------------------------------------
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ NS_ASSUME_NONNULL_BEGIN

+ (nullable NSString *)campaignIdentifierFromRemoteNotificationPayload:(NSDictionary *)payload;

+ (void)logButtonAction:(FBNCardButtonAction)action forCardWithCampaignIdentifier:(NSString *)identifier;
+ (void)logCardOpenWithCampaignIdentifier:(nullable NSString *)identifier;
+ (void)logButtonAction:(FBNCardButtonAction)action forCardWithCampaignIdentifier:(nullable NSString *)identifier;

@end

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,24 +36,34 @@ + (nullable NSString *)campaignIdentifierFromRemoteNotificationPayload:(NSDictio
return payload[@"fb_push_payload"][@"campaign"];
}

+ (void)logButtonAction:(FBNCardButtonAction)action forCardWithCampaignIdentifier:(NSString *)identifier {
+ (void)logCardOpenWithCampaignIdentifier:(nullable NSString *)identifier {
if (!identifier) {
return;
}
[self _logAppEventWithName:@"fb_mobile_push_opened" campaignIdentifier:identifier];
}

Class loggerClass = NSClassFromString(@"FBSDKAppEvents");
if (loggerClass && [loggerClass respondsToSelector:@selector(logEvent:parameters:)]) {
NSString *eventName = [self _appEventNameForButtonAction:action];
if (eventName) {
[loggerClass logEvent:eventName parameters:@{ @"fb_push_campaign" : identifier }];
}
}
+ (void)logButtonAction:(FBNCardButtonAction)action forCardWithCampaignIdentifier:(nullable NSString *)identifier {
NSString *eventName = [self _appEventNameForButtonAction:action];
[self _logAppEventWithName:eventName campaignIdentifier:identifier];
}

///--------------------------------------
#pragma mark - Private
///--------------------------------------

+ (void)_logAppEventWithName:(NSString *)name campaignIdentifier:(NSString *)identifier {
if (!identifier) {
return;
}

Class loggerClass = NSClassFromString(@"FBSDKAppEvents");
if (loggerClass && [loggerClass respondsToSelector:@selector(logEvent:parameters:)]) {
[loggerClass logEvent:name
parameters:@{ @"fb_push_campaign" : identifier }];
}
}

+ (nullable NSString *)_appEventNameForButtonAction:(FBNCardButtonAction)action {
switch (action) {
case FBNCardButtonActionPrimary:
Expand Down